Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PYMT-1313 Fix issues with phpstan and ide autocomplete #23

Merged
merged 2 commits into from Oct 9, 2019

Conversation

@merk
Copy link
Collaborator

commented Oct 9, 2019

The initial implementation of these provider specific services didnt allow for .phpstorm.meta.php from working correctly. Factory methods must have their return types as the first parameter to work.

This fixes that (+ minor service provider issue).

merk added 2 commits Oct 9, 2019
Copy link
Contributor

left a comment

LGTM 👍

@merk merk merged commit 82995e7 into development Oct 9, 2019
1 check passed
1 check passed
Bamboo CI Build passed
Details
@merk merk deleted the feature/PYMT-1313-fix-ide-issues branch Oct 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
You can’t perform that action at this time.