diff --git a/src/net/http/httptest/server.go b/src/net/http/httptest/server.go index b5b18c747d9b2a..549ef0462389c9 100644 --- a/src/net/http/httptest/server.go +++ b/src/net/http/httptest/server.go @@ -209,8 +209,10 @@ func (s *Server) Close() { } // Also close the client idle connections. - if t, ok := s.client.Transport.(closeIdleTransport); ok { - t.CloseIdleConnections() + if s.client != nil { + if t, ok := s.client.Transport.(closeIdleTransport); ok { + t.CloseIdleConnections() + } } s.wg.Wait() diff --git a/src/net/http/httptest/server_test.go b/src/net/http/httptest/server_test.go index 62846de02cd582..d97cec5fdd5329 100644 --- a/src/net/http/httptest/server_test.go +++ b/src/net/http/httptest/server_test.go @@ -145,3 +145,20 @@ func TestTLSServerClientTransportType(t *testing.T) { t.Errorf("got %T, want *http.Transport", client.Transport) } } + +type onlyCloseListener struct { + net.Listener +} + +func (onlyCloseListener) Close() error { return nil } + +// Issue 19729: panic in Server.Close for values created directly +// without a constructor (so the unexported client field is nil). +func TestServerZeroValueClose(t *testing.T) { + ts := &Server{ + Listener: onlyCloseListener{}, + Config: &http.Server{}, + } + + ts.Close() // tests that it doesn't panic +}