Repository navigation
Don't tie USART clock to specific USART instance; cleanups - #223
Merged
Merged
Conversation
With the added space and changed grouping, I find this much easier to read.
This follows the typical Rust naming style better.
I find imports easier to read when the different types are separated, and in a consistent order: From most general (`core`), to most specific (`self`, `super`).
I think it's easier to find there. I also think this is more clear than having all the various clock in one module.
It's already in the `usart` module, so the name is redundant.
It seems like the logical place. When I searched for it, I was surprised to find it in `syscon`.
It's neither used nor implemented on LPC82x, but having it available everywhere will make some of the following clean-ups easier.
There's really no reason to do so. It just prevents the same configuration from being reused for multiple instances, requiring more lines of code.
It's not stricly required for LPC82x, but having it generally available will make some clean-ups possible, that are going to reduce code duplication.
This reduces code duplication between the different targets, and makes them a bit easier to find.
This makes their names and definition consistent with the style used in the rest of the `usart` module.
hannobraun
marked this pull request as ready for review
March 17, 2020 10:29
Member
Author
|
Rebased, ready for review. |
david-sawatzke
approved these changes
Mar 17, 2020
david-sawatzke
left a comment
david-sawatzke
left a comment
Member
There was a problem hiding this comment.
Looks good!
Parts of it were really needed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on #222. I recommend reviewing/merging that one first.
Originally I just meant to remove the connection between a USART clock a specific USART instance, as that's not necessary, and prevents re-use of configuration between multiple USART instances (which is a bit annoying). It turned into a meandering cleanup operation of USART clock code.