Finish my current round of clock source clean-up #239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `&()` I had to add isn't pretty, but I think it's worth it. We can define more targeted types in the future, to make this more understandable. And to fix (insert words to prevent GitHub from closing that issue) #205, we might have to anyway. In any case, this is how far I'm willing to go right now, and I think it's good enough.
Maybe the duplication could be removed, but I think this would require a closer reading of the user manual than I'm willing to do right now. I don't feel the need to make this perfect right now, since there's very little duplication left anyway. And since we likely want to support other main clock frequencies at some point, we'll have to revisit this code then anyway.
I believe keeping the target-specific code small and inline is more readable than having the sub-module, and this is the style I've already been implementing in other code.
|
The Travis build fails on nightly only, because |
david-sawatzke
approved these changes
May 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
The clock source code is not perfect by any means, but I think this PR leaves it in a good enough state to focus on other stuff for a while.