Repository navigation
Add support for SPI slave mode - #259
Merged
Merged
Conversation
Slave mode needs explicit support for the slave select pins to work, and since there are multiple per peripheral, we need a trait to identify them.
I'm about to add support for slave mode, which will require a second enable method.
Once support for slave mode is added, there will no longer be a clear default.
Those are going to be reused by slave mode initialization.
They are not used, and the restrictions they provide are redundant. The function types are already restricted to those used in the `Instance` trait and a `Function` cannot be assigned without all the right traits being there anyway.
This helps when using an IDE that shows you the name of the arguments when writing a function call.
Some of these are required to operate slave mode, but they're available in master mode and might be useful there too.
david-sawatzke
approved these changes
Jul 23, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.