Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DMA support for I2C master mode #264

merged 13 commits into from Aug 3, 2020

Add DMA support for I2C master mode #264

merged 13 commits into from Aug 3, 2020


Copy link

Based on #263. I recommend reviewing/merging that one first.

The other methods are sorted roughly in the order they are used, but
this one wasn't.
The new name still covers what it's currently used for, while being a
better match for future use cases.
This way the code can be re-used for DMA.
This will help with implementing the DMA operations.
This is going to be needed for I2C.
Without waiting for `RxReady` before stopping the read operation, it is
possible that the STOP doesn't work, and the peripheral is left in
`RxReady` instead of `Idle`.

I didn't encounter this previously, but it happens regularly when
reading with DMA.
Copy link
Member Author

Rebased, ready for review.

@hannobraun hannobraun marked this pull request as ready for review July 30, 2020 14:50
@hannobraun hannobraun merged commit e11be33 into lpc-rs:master Aug 3, 2020
@hannobraun hannobraun deleted the i2c-dma branch August 3, 2020 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants