Add DMA support for I2C master mode #264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 29, 2020
The other methods are sorted roughly in the order they are used, but this one wasn't.
The new name still covers what it's currently used for, while being a better match for future use cases.
This way the code can be re-used for DMA.
This will help with implementing the DMA operations.
This is going to be needed for I2C.
Without waiting for `RxReady` before stopping the read operation, it is possible that the STOP doesn't work, and the peripheral is left in `RxReady` instead of `Idle`. I didn't encounter this previously, but it happens regularly when reading with DMA.
|
Rebased, ready for review. |
david-sawatzke
approved these changes
Aug 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #263. I recommend reviewing/merging that one first.