-
Notifications
You must be signed in to change notification settings - Fork 8
Add DMA support for SPI master mode #265
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Rebased, still blocked on #264. |
Rebased, ready for review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A usage example or something similar would also help (maybe a loopback detection, as a self contained system?).
Only the unreachable()
stuff is a blocker for me
I do have a usage example over here: https://github.com/braun-embedded/lpc845-test-stand/blob/22de685de7664273169232f20b330954512fc007/test-target/src/main.rs#L621-L650 I agree that it would be better to have a self-contained example using loopback mode in this repository, but I'd like to leave that as a possible future improvement, if at all possible. I'm already very late in my current project, and my focus right now is to finish up the last few tasks so I can take a long vacation. For this reason, I'd like to avoid any additional non-trivial tasks (which this is, as it includes API design work). |
This required adding some additional infrastructure that is distinct from the DMA infrastructure used by other peripherals, as SPI can send and receive at the same time, using the same buffer.
Pushed a commit that adds Merging, as everything is resolved now (and my test suite still runs fine). |
This pull request is based on #263 and #264. I recommend reviewing/merging those first.