Add methods to query flags and enable/disable interrupts for USART #267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
david-sawatzke
approved these changes
Aug 2, 2020
This is an improved version the macros founds in other peripheral modules. It can be used to not only enable/disable interrupts with a minimal amount of repetition and manual code, it allows the same for querying/resetting flags. I believe it should be relatively straight-forward to make this macro peripheral-agnostic and move it to a shared module, where it can be used for all of the peripheral APIs. As a final note, I think this macro is right at the edge of complexity where a procedural macro starts to make sense. I don't want to go into that right now, as that would require adding an additional crate, but I think we should keep that in mind as an option for the future.
Replaces the more specific methods for RXRDY and TXRDY that were already there.
|
Rebased, already approved. Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is based on #266. I recommend reviewing/merging that one first.