Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add methods to query flags and enable/disable interrupts for USART #267

merged 3 commits into from Aug 3, 2020

Add methods to query flags and enable/disable interrupts for USART #267

merged 3 commits into from Aug 3, 2020


Copy link

This pull request is based on #266. I recommend reviewing/merging that one first.

This is an improved version the macros founds in other peripheral
modules. It can be used to not only enable/disable interrupts with a
minimal amount of repetition and manual code, it allows the same for
querying/resetting flags.

I believe it should be relatively straight-forward to make this macro
peripheral-agnostic and move it to a shared module, where it can be used
for all of the peripheral APIs.

As a final note, I think this macro is right at the edge of complexity
where a procedural macro starts to make sense. I don't want to go into
that right now, as that would require adding an additional crate, but I
think we should keep that in mind as an option for the future.
Replaces the more specific methods for RXRDY and TXRDY that were already
@hannobraun hannobraun marked this pull request as ready for review August 3, 2020 19:03
Copy link
Member Author

Rebased, already approved. Merging.

@hannobraun hannobraun merged commit fe75505 into lpc-rs:master Aug 3, 2020
@hannobraun hannobraun deleted the usart-flags branch August 3, 2020 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants