Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for synchronous USART mode #271

Merged
merged 15 commits into from Aug 11, 2020
Merged

Add support for synchronous USART mode #271

merged 15 commits into from Aug 11, 2020

Conversation

hannobraun
Copy link
Member

No description provided.

@hannobraun
Rename method
782669b 
I'm working on adding support for synchronous mode to the USART API,
which would make this method name too unspecific.
@hannobraun
Add type state to track USART mode
e553ca1
@hannobraun
Reduce visibility of usart::Clock fields
53802d4 
`pub(crate)` is no longer required since the big clock refactoring.
@hannobraun
Add type state to track mode to usart::Clock
7e7cb1f 
This is required because the clock is handled differently in synchronous
and asynchronous mode.
@hannobraun
Update usart::Clock documentation
562f35a
@hannobraun
Move some USART init code to separate method
f95e9af 
This method can be shared between the enable methods for the different
modes.
@hannobraun
Fix link in documentation
ede2606
@hannobraun
Add SCLK function to usart::Instance
0e96990
@hannobraun
Add method to apply non-mode-specific config
53cc1ed 
This method can be reused by other enable methods for other modes.
@hannobraun
Remove unneeded trait bounds
4bb7573 
They are redundant, as everything they guarantee is already guaranteed
by the correct choice of pins in the `usart::Instance` implementations.
@hannobraun
Add method to enable USART in sync mode as master
036bb76
@hannobraun
Add method to enable USART in sync mode as slave
8ec12f4
@hannobraun hannobraun mentioned this pull request Aug 7, 2020
Merged
david-sawatzke
david-sawatzke requested changes Aug 10, 2020
View reviewed changes
Copy link
Member

@david-sawatzke david-sawatzke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM otherwise

src/usart/peripheral.rs Outdated Show resolved Hide resolved
src/usart/peripheral.rs Outdated Show resolved Hide resolved
src/usart/peripheral.rs Outdated Show resolved Hide resolved
src/usart/state.rs Outdated Show resolved Hide resolved
src/usart/state.rs Outdated Show resolved Hide resolved
hannobraun and others added 3 commits August 11, 2020 13:50
@hannobraun @david-sawatzke
Apply suggestions from code review
1b72f42 
Fix comment typos

Co-authored-by: david-sawatzke <david-sawatzke@users.noreply.github.com>
@hannobraun
Shorten comment, and put it in the correct places
f19ab8b
@hannobraun
Remove inaccurate comments
1480812
@hannobraun
Copy link
Member Author

Thanks for the review! Pushed new commits to address the comments. Should be good to go now.

@hannobraun hannobraun merged commit fb920d2 into lpc-rs:master Aug 11, 2020
@hannobraun hannobraun deleted the usart-sync branch August 11, 2020 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@david-sawatzke david-sawatzke david-sawatzke approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@hannobraun @david-sawatzke