New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Network interface information doesn't show icons #304

Closed
lpereira opened this Issue Nov 4, 2018 · 1 comment

Comments

Projects
None yet
2 participants
@lpereira
Owner

lpereira commented Nov 4, 2018

Icons aren't being shown any longer for any of the information screens, including network interface, storage, input, etc.

@bp0 bp0 added the bug label Nov 4, 2018

@bp0

This comment has been minimized.

Collaborator

bp0 commented Nov 4, 2018

git bisect points to 9eaf1a7

hardinfo -m network.so -s -r -f shell -w >~/hi_shell_dump.txt

Network
*******

Interfaces
----------

[Network Interfaces]
$NETlo$lo=127.0.0.1|19.50MiB|19.50MiB
    [Network Adapter Properties]
    Interface Type=Loopback
    Hardware Address (MAC)=00:00:00:00:00:00
    MTU=65536
    [Transfer Details]
    Bytes Received=20446443 (19.50MiB)
    Bytes Sent=20446443 (19.50MiB)
    
    [Internet Protocol (IPv4)]
    IP Address=127.0.0.1
    Mask=255.0.0.0
    Broadcast Address=0.0.0.0
$NETenp3s0$enp3s0=192.168.1.131|726.49MiB|30784.65MiB
    [Network Adapter Properties]
    Interface Type=Ethernet
    Hardware Address (MAC)=10:7b:44:a5:66:2f
    MTU=1500
    [Transfer Details]
    Bytes Received=32280044473 (30784.65MiB)
    Bytes Sent=761780188 (726.49MiB)
    
    [Internet Protocol (IPv4)]
    IP Address=192.168.1.131
    Mask=255.255.255.0
    Broadcast Address=192.168.1.255

[$ShellParam$]
ReloadInterval=3000
ViewType=1
ColumnTitle$TextValue=Interface
ColumnTitle$Value=IP Address
ColumnTitle$Extra1=Sent
ColumnTitle$Extra2=Received
ShowColumnHeaders=true
Icon$NETlo$lo=network.png
Icon$NETenp3s0$enp3s0=network-interface.png
...

bp0 added a commit to bp0/hardinfo that referenced this issue Nov 5, 2018

Fix missing icons
Fixes lpereira#304

After 9eaf1a7, the
whole key part, including the opening and closing '$',
is stored in DATACOL so that the key_*() functions
can be used against it anywhere.

The first '$' no longer needs to be skipped.

Signed-off-by: Burt P <pburt0@gmail.com>

bp0 added a commit to bp0/hardinfo that referenced this issue Nov 5, 2018

Fix missing icons
Fixes lpereira#304

After 9eaf1a7, the
whole key part, including the opening and closing '$',
is stored in INFO_TREE_COL_DATA so that the
key_*() functions can be used against it anywhere.

The first '$' no longer needs to be skipped.

Signed-off-by: Burt P <pburt0@gmail.com>

@bp0 bp0 referenced this issue Nov 5, 2018

Merged

Fix missing icons #305

@lpereira lpereira closed this in #305 Nov 6, 2018

lpereira added a commit that referenced this issue Nov 6, 2018

Fix missing icons
Fixes #304

After 9eaf1a7, the
whole key part, including the opening and closing '$',
is stored in INFO_TREE_COL_DATA so that the
key_*() functions can be used against it anywhere.

The first '$' no longer needs to be skipped.

Signed-off-by: Burt P <pburt0@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment