Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to Add a Benchmark Result #458

Open
bp0 opened this issue Aug 29, 2019 · 3 comments

Comments

@bp0
Copy link
Collaborator

commented Aug 29, 2019

It would be nice to have some more bench result for comparison, but I have only a few machines, so help from others is needed and requested.
Until an automatic bench submission framework is complete, here is the best way to submit bench results to Hardinfo.

First:
Fork Hardinfo, build and install following the instructions at #325 (comment), modifying them to pull from YOUR FORK.

Then:

# From the hardinfo git root, run:
git checkout -b myresult
cd build 
# The build directory should exist from building the latest Hardinfo.
# Using `build/` will keep the git tree clean.
bash ../test/just_bench.sh >mybench.conf
crudini --merge ../data/benchmark.conf <mybench.conf
# Examine the changes:
git diff
# Only benchmark.conf should change, and the added lines 
# should be the new results.
git add ../data/benchmark.conf
git commit -m "add bench result ..."
git push -u origin myresult
# Go to https://github.com/lpereira/hardinfo and open a Pull Request.
@lpereira

This comment has been minimized.

Copy link
Owner

commented Aug 29, 2019

@bp0

This comment has been minimized.

Copy link
Collaborator Author

commented Aug 29, 2019

I think this process will do, but until all that can be done, but I wonder if it would be worth it to have an "Export Result" that would create a block of text that could be pasted into a thread like this.

@lpereira

This comment has been minimized.

Copy link
Owner

commented Aug 29, 2019

Can't make a PR right now, but here's some results:
results.txt

bp0 added a commit to bp0/hardinfo that referenced this issue Aug 30, 2019
@bp0 bp0 referenced this issue Aug 30, 2019
lpereira added a commit that referenced this issue Aug 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.