Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dogma should not be a production dependency #167

Closed
wants to merge 1 commit into from

Conversation

@johnhamelink
Copy link

commented Nov 18, 2015

Hey there,

I noticed that the readme recommends you install Dogma only specifying that it should be run in development - to me it seems that Dogma should also be run in the test environment also.

@lpil

This comment has been minimized.

Copy link
Owner

commented Nov 18, 2015

Why is this? Are you using Dogma in your tests somehow?

Could you change the commit message to be accurate please?

Thanks :)

@johnhamelink

This comment has been minimized.

Copy link
Author

commented Nov 18, 2015

@lpil Thanks for getting back to me so quick!

Are you using Dogma in your tests somehow?

I could be using Dogma in CI where I would be running the code in a test environment - this was the primary use case I had in mind.

Could you change the commit message to be accurate please?

Done

@lpil

This comment has been minimized.

Copy link
Owner

commented Nov 18, 2015

I feel this is the responsibility of the person running Dogma The minimum required to run Dogma is for it to be in the :dev env.

@johnhamelink

This comment has been minimized.

Copy link
Author

commented Nov 18, 2015

@lpil I agree, but disagree that the minimum is the most helpful for new users in this case. I'll close this PR.

Thanks for Dogma, keep up the great work, I hope I'll be able to contribute to it in a more meaningful way sometime in the near future! 🚀

@lpil

This comment has been minimized.

Copy link
Owner

commented Nov 18, 2015

Thank you John. If you think this is something worth documenting, maybe we should add a new docs page that contained information on running Dogma on CI :)

Cheers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.