Luigi Pinca
lpinca

  • Foligno (PG), Italy
  • Joined on Feb 16, 2012

Organizations

@primus @unshiftio
Jul 23, 2016
lpinca commented on pull request primus/primus#477
@lpinca

How about shipping primus@6.0.0? I can't think of anything else to add or fix. If there are no objections I'll cut a new release later today or tom…

Jul 23, 2016
lpinca pushed to master at primus/primus
@lpinca
  • @lpinca 0650c58
    [deps] Bump request to version 2.74.x
lpinca deleted branch max-length at primus/primus
Jul 23, 2016
Jul 23, 2016
lpinca pushed to master at primus/primus
@lpinca
Jul 23, 2016
lpinca merged pull request primus/primus#477
@lpinca
Introduce the `maxLength` option
1 commit with 158 additions and 142 deletions
Jul 23, 2016
lpinca commented on issue nodejs/nodejs.org#839
@lpinca

+1 to disable merge commits and only allow squash merging.

Jul 23, 2016
@lpinca

@iamandrebulatov http://shopify.github.io/ only lists official Shopify projects. Regarding http://opensourceforshopify.com, we should probably crea…

Jul 22, 2016
lpinca commented on pull request nodejs/nodejs.org#838
@lpinca

I can do that but it should only test that the content is trimmed as the other parts (author / version policy extraction, shasum etc.) are already …

Jul 22, 2016
lpinca commented on pull request nodejs/nodejs.org#838
@lpinca

@evanlucas yeah I thought about that but it requires a new fixture.

Jul 22, 2016
lpinca opened pull request nodejs/nodejs.org#838
@lpinca
Make the release-post script more tolerant
1 commit with 3 additions and 1 deletion
lpinca created branch gh-837 at nodejs/nodejs.org
Jul 22, 2016
Jul 22, 2016
lpinca commented on issue nodejs/nodejs.org#837
@lpinca

The problem is in these two regex 1, 2. The second one does not match as there is a leading \n. I think the beast approach to fix this is to trim t…

Jul 22, 2016
lpinca commented on pull request nodejs/nodejs.org#833
@lpinca

It worked.

lpinca deleted branch update/semver at nodejs/nodejs.org
Jul 22, 2016
Jul 22, 2016
@lpinca
  • @lpinca bd2149b
    Update semver to version 5.3.0 (#836)
Jul 22, 2016
lpinca merged pull request nodejs/nodejs.org#836
@lpinca
Update semver to version 5.3.0
1 commit with 1 addition and 1 deletion
Jul 22, 2016
lpinca commented on pull request nodejs/nodejs.org#833
@lpinca

here we go #836.

Jul 22, 2016
lpinca opened pull request nodejs/nodejs.org#836
@lpinca
Update semver to version 5.3.0
1 commit with 1 addition and 1 deletion
Jul 22, 2016
Jul 22, 2016
lpinca commented on pull request nodejs/nodejs.org#833
@lpinca

No but I'll send a pr with a dep update and once merged it should be deployed again.

Jul 22, 2016
lpinca commented on pull request nodejs/nodejs.org#833
@lpinca

Everything is ok when running the site locally, so I think this script failed to pick up the latest version. Maybe https://nodejs.org/download/rele…

Jul 21, 2016
lpinca commented on pull request nodejs/node#7822
@lpinca

I missed quite a few things, thanks for reviewing @mscdex.

Jul 21, 2016
@lpinca
  • @lpinca cbc3836
    doc: add `added:` information for events
Jul 21, 2016
@lpinca
  • @lpinca 6e3999d
    doc: add `added:` information for events
Jul 21, 2016
@lpinca
  • @lpinca 7bbdd3b
    doc: add `added:` information for events
Jul 21, 2016
lpinca commented on pull request nodejs/node#7822
@lpinca

You are correct, I'll fix it.

Jul 21, 2016
lpinca opened pull request nodejs/node#7822
@lpinca
doc: add `added:` information for events
1 commit with 48 additions and 0 deletions
lpinca created branch add/added-events at lpinca/node
Jul 21, 2016
Jul 21, 2016
lpinca commented on pull request cayasso/primus-multiplex#28
@lpinca

Thank you. 👍