Skip to content
This repository has been archived by the owner on Oct 13, 2023. It is now read-only.

run molecule test with vagrant #47

Merged
merged 2 commits into from
Jan 11, 2022
Merged

run molecule test with vagrant #47

merged 2 commits into from
Jan 11, 2022

Conversation

oukooveu
Copy link
Contributor

ability to run vagrant tests locally has been added, additionally i've updated sonarqube versions (to latest lts).

@chronicc
Copy link

chronicc commented Jan 10, 2022

I want to propose to put the requirements.txt at the root level of the repository, since this is the place where one would expect this file. Also I think all molecule scenarios would need this requirements file to function, not only the vagrant scenario.

If the usage of virtualenv is not a hard decission, I also want to propose to use poetry for setting up the environment, which is more comfortable in the long run by only needing to run poetry shell inside the repository. This way noone needs to remember where the virtualenv path is stored.

@lrk
Copy link
Owner

lrk commented Jan 10, 2022

I want to propose to put the requirements.txt at the root level of the repository, since this is the place where one would expect this file. Also I think all molecule scenarios would need this requirements file to function, not only the vagrant scenario.

If the usage of virtualenv is not a hard decission, I also want to propose to use poetry for setting up the environment, which is more comfortable in the long run by only needing to run poetry shell inside the repository. This way noone needs to remember where the virtualenv path is stored.

@chronicc i don't mind using poetry, i didn't know about it beforehand, but if it's helping to keep thing simple AND don't add to much dependencies, why not.

You can create a PR with your proposed modifications, but i'd like to see the README.md file to contains steps to setup local env with poetry and with default python commands.

@lrk lrk merged commit cddf18e into lrk:master Jan 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants