Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Links need to be URI encoded #9

Closed
wants to merge 1 commit into
from

Conversation

2 participants

Hi,

First off, I love this project.

My first test happened to have some weirdly named files: "10%20Another%20Bloody%20Election-192.mp3" which was being (correctly) rendered by apache as "10%2520Another%2520Bloody%2520Election-192.mp3". H5ai was decoding the URI as it read the apache html (which puts it back to "10%20Another%20Bloody%20Election-192.mp3") but when writing it out it wasn't re-encoding it. This ended up losing one level of encoding and the link became incorrect and unreachable (apache was looking for "10 Another Bloody Election-192.mp3" in the directory which doesn't exist).

My change adds URI encoding to the output so that strange files like the above work just fine.

-David

Owner

lrsjng commented Jul 24, 2011

Thanks! Didn't have such a use case so far. Your fix on that isn't sufficient and has some side effects. Fixed it by don't decode the href and absHref attributes, but only the labels.

Fixed in release 0.10

@lrsjng lrsjng closed this Jul 24, 2011

@lrsjng lrsjng added a commit that referenced this pull request Jul 24, 2011

@lrsjng lrsjng * fixed problems with XAMPP on Windows (see dot.htaccess comments for…
… instructions)

* fixed tree fade-in-fade-out effect for small displays ([issue #6](http://github.com/lrsjng/h5ai/issues/6))
* added custom scrollbar to tree ([issue #6](http://github.com/lrsjng/h5ai/issues/6))
* fixed broken links caused by URI encoding/decoding ([issue #9](http://github.com/lrsjng/h5ai/issues/9))
* added "empty" to localization (hope Google Translate did a good job here)
5708b2e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment