Updating to ruby 2.7.2 #144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
h-lame
reviewed
Nov 26, 2020
h-lame
approved these changes
Nov 26, 2020
There was a problem hiding this comment.
Looks great, thanks @MikeRogers0. I'll merge once travis is happy.
|
@h-lame - Re:Travis, I've seen a few repos move over to Github Actions - any thoughts about making the switch? |
Definitely thought about it, but we use a custom deploy package thing that we'd need to reimplement or reimagine and I've not spent enough time investigating what's out there already to replicate as much as possible. I don't think we've a huge need to as it's all free for now anyway. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pulled from #143
This updates the Ruby version used to 2.7.2. When I ran
bundle exec middleman buildlocally the only warning was:Which is currently expected ( middleman/middleman#2312 ), so not a big worry :)