LTP:fixed fallocate01 tests #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 3, 2020 16:58
hukoyu
requested changes
Aug 4, 2020
added 2 commits
August 4, 2020 11:01
hukoyu
approved these changes
Aug 5, 2020
|
This need some root cause analysis. Why does fallocate not work in the tmp directory? |
|
@davidchisnall , @SeanTAllen submitted a fix for /tmp file create issue: lsds/sgx-lkl#723 |
|
This needs a corresponding PR on sgx-lkl so that CI is run with this change. Please speak to @hukoyu if you aren't familiar with how to do that. |
|
@hukoyu : In the latest code changes the test is failing on /tmp directory after pr lsds/sgx-lkl#723 merged |
SeanTAllen
reviewed
Aug 7, 2020
SeanTAllen
reviewed
Aug 7, 2020
SeanTAllen
suggested changes
Aug 7, 2020
|
@SeanTAllen Addressed comments. Could you please review |
SeanTAllen
approved these changes
Aug 10, 2020
This was referenced Aug 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test Failure reason in SGX-LKL:
[[ SGX-LKL ]] libc_start_main_stage2(): Calling app main: /ltp/testcases/kernel/syscalls/fallocate/fallocate01
fallocate01 1 TCONF : fallocate01.c:233: fallocate system call is not implemented
Test is happening on temporary file created under /tmp, on which fallocate system call is failing.
fallocate system call is failing on temporary file created under /tmp directory.
So modified the tests to create directory in root filesystem.