Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP
Commits on Jun 10, 2012
  1. @kou

    i18n: make gettext gem optional

    kou authored
    Require gettext related files lazy and ignore LoadError.
Commits on Jun 6, 2012
Commits on May 20, 2012
  1. @kou
  2. @kou
  3. @kou

    i18n: add YARD::I18n::Locale

    kou authored
Commits on May 2, 2012
  1. @kou

    i18n: create YARD::I18n::Messages and Message

    kou authored
    This commit is corresponding to comment in #527:
    
      #527 (comment)
    
      One thing I noticed after you documented the code is that
      PotGenerator#messages has a very long type signature. To me, this
      usually implies that the API is equally complex to use. The type:
      Hash{:locations => Array<Array[String, Integer]>, :comments =>
      Array<String>} to me screams of refactoring into a separate class with
      .locations and .comments attributes. That way we can have a properly
      documented Message (would this be the right name? or PotMessage?)
      class component that has meaning in our system, and #messages would
      turn into Hash{String=>Message}, which is much clearer to me. Can you
      do this refactor?
Commits on Apr 30, 2012
  1. @kou

    i18n: move YARD::CLI::I18n::* to YARD::I18n::*

    kou authored
    This commit is corresponding to 1. and 3. in #395:
    
      #395 (comment)
    
      1. I'd like it if you could move your CLI::I18n subclasses into a
      YARD::I18n namespace. I'm not a fan of classes inside of classes,
      organizationally speaking, and it's hard to promote component reuse
      for these classes if they're inside of a CLI namespace. Presumably
      someone might want to use the PotGenerator class directly, for
      instance, and they shouldn't have to go through the CLI. So, I've
      marked those classes as @private for now so that nobody uses them
      from that namespace. Once you move them into a more appropriate
      location, you can remove the @private declaration and we can support
      them as a public API.
    
      3. Ditto for moving the tests for the inner classes like
      PotGenerator and Test into their own files. I'm also not a fan of
      multiple classes in a single _spec.rb file.
Something went wrong with that request. Please try again.