Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix rescue clause #1198

Merged
merged 1 commit into from Jan 23, 2019
Merged

Fix rescue clause #1198

merged 1 commit into from Jan 23, 2019

Conversation

skalee
Copy link
Contributor

@skalee skalee commented Oct 6, 2018

Description

In case of ArgumentError unrelated to encoding, it used to enter an infinite loop.

Completed Tasks

  • I have read the Contributing Guide.
  • The pull request is complete (implemented / written).
  • Git commits have been cleaned up (squash WIP / revert commits).
  • [?] I wrote tests and ran bundle exec rake locally (if code is attached to PR). — it is really a border case which would affect contributors rather than users. More serious things are untested. Nevertheless, I can write some, if needed.

@skalee
Fix rescue clause
cea13da 
In case of ArgumentError unrelated to encoding, it used to enter an
infinite loop.
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.005%) to 93.636% when pulling cea13da on skalee:fix-exception-handling into c26eeda on lsegal:master.

3 similar comments
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.005%) to 93.636% when pulling cea13da on skalee:fix-exception-handling into c26eeda on lsegal:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.005%) to 93.636% when pulling cea13da on skalee:fix-exception-handling into c26eeda on lsegal:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.005%) to 93.636% when pulling cea13da on skalee:fix-exception-handling into c26eeda on lsegal:master.

@lsegal lsegal merged commit 65b152b into lsegal:master Jan 23, 2019
@skalee skalee deleted the fix-exception-handling branch March 30, 2019 14:10
lsegal added a commit that referenced this pull request Apr 2, 2019
@lsegal
Tag release v0.9.19
12f56cf 
References:
  #1071, #1198, #1219, #1226, #1228, #1229, #1231, #1233,
  #1234, #1235
This was referenced Mar 12, 2021
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@skalee @coveralls @lsegal