Skip to content

JavaScript bug fix for the default template. #706

Merged
merged 1 commit into from Nov 1, 2013

2 participants

@trevorrowe

When using the frames view in the default template, it attempts to set the page title when you load a page in the
main frame. If you are serving content from disk using file://, some browsers, like Chrome, will raise an error. This stops the rest of the JavaScript on the page from running.

This pull request adds a try-catch block around the window title assignment statement. In the case when this fails, the title simply is not updated.

@trevorrowe trevorrowe JavaScript bug fix for the default template.
When using the frames view in the default template,
it attempts to set the page title when you load a page in the
main frame.  If you are serving content from disk using file://,
some browsers, like Chrome, will raise an error. This stops
the rest of the JavaScript on the page from running.

This pull request adds a try-catch block around the window title
assignment statement.  In the case when this fails, the title simply
is not updated.
6fc539b
@lsegal lsegal merged commit baebdab into lsegal:master Nov 1, 2013

1 check passed

Details default The Travis CI build passed
@lsegal
Owner
lsegal commented Nov 1, 2013

Thanks Trevor!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.