Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The controls' order in panel differs from the order of declaration #181

Closed
danchanka opened this issue Oct 1, 2019 · 1 comment
Closed

Comments

@danchanka
Copy link
Collaborator

@danchanka danchanka commented Oct 1, 2019

image (4)

@danchanka

This comment has been minimized.

Copy link
Collaborator Author

@danchanka danchanka commented Oct 4, 2019

The problem could be reproduced in containers with columns in desktop and web clients. One of the reasons is the wrong calculation of column index in addImpl and removeImpl methods in ColumnClientContainerView class (desktop client):

 int childIndex = container.children.indexOf(child);
 int colIndex = childIndex % columnsCount;

This code doesn't use the calculated index that is passed to the method. It could be replaced with

    int colIndex = index % columnsCount;

But the main problem is the online column distribution. The code in addImpl determines column and row of the component in the situation when the final index of the component is not known.

One of the possible fixes is to rebuild column distribution after every addition or deletion of a component. But in this case, controls would be shifted to other columns.

@danchanka danchanka closed this in c4d9905 Oct 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
You can’t perform that action at this time.