NSS: ECDSA updates #172
Merged
NSS: ECDSA updates #172
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This test started to fail when 2ae6192 (MS CNG: adopt trusted certificate (lsh123#141), 2018-01-15) fixed the typo in the test to require ecdsa key data. The implementation was there, just not the registration. Testcase: aleksey-xmldsig-01/enveloping-sha256-ecdsa-sha256
The condition is now consistent with the RSA getter. In practice this fixes a crash when using libxmlsec via its API and setting only the private key (but not the public key) for signing -- as SECKEY_GetPublicKeyType(NULL) is not safe. Bugreport: https://bugs.documentfoundation.org/show_bug.cgi?id=109180
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two fixes for the ECDSA support in the NSS backend.