mscng: fix use-after-free #192
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I hit this while porting LibreOffice from the mscrypto to the mscng backend. The apps/ code doesn't trigger this codepath, but calling xmlSecDSigCtxVerify() from external code can.
…e hash handle The new order of cleanup matches MSDN documentation and fixes this drmemory error: Error lsh123#1: UNADDRESSABLE ACCESS of freed memory: reading 0x0092c5e0-0x0092c5e4 4 byte(s) # 0 bcrypt.dll!BCryptDestroyHash +0x74 (0x72701ad3 <bcrypt.dll+0x1ad3>) # 1 bcrypt.dll!BCryptDestroyHash +0xe (0x72701a6e <bcrypt.dll+0x1a6e>) # 2 libxmlsec-mscng.dll!xmlSecMSCngSignatureFinalize [xmlsec\src\mscng\signatures.c:274] # 3 libxmlsec.dll!xmlSecTransformDestroy [xmlsec\src\transforms.c:1271] # 4 libxmlsec.dll!xmlSecTransformCtxReset [xmlsec\src\transforms.c:394] # 5 libxmlsec.dll!xmlSecTransformCtxFinalize [xmlsec\src\transforms.c:361] # 6 libxmlsec.dll!xmlSecDSigCtxFinalize [xmlsec\src\xmldsig.c:178] # 7 xmlSecAppVerifyFile [xmlsec\apps\xmlsec.c:1324] # 8 main [xmlsec\apps\xmlsec.c:1091] Note: @0:00:02.891 in thread 2640 Note: prev lower malloc: 0x0092c5a0-0x0092c5bc Note: 0x0092c5e0-0x0092c5e4 overlaps memory 0x0092c5e0-0x0092c692 that was freed here: Note: # 0 replace_free [d:\drmemory_package\common\alloc_replace.c:2706] Note: # 1 libxmlsec-mscng.dll!xmlSecMSCngSignatureFinalize [xmlsec\src\mscng\signatures.c:270] Note: # 2 libxmlsec.dll!xmlSecTransformDestroy [xmlsec\src\transforms.c:1271] Note: # 3 libxmlsec.dll!xmlSecTransformCtxReset [xmlsec\src\transforms.c:394] Note: # 4 libxmlsec.dll!xmlSecTransformCtxFinalize [xmlsec\src\transforms.c:361] Note: # 5 libxmlsec.dll!xmlSecDSigCtxFinalize [xmlsec\src\xmldsig.c:178] Note: # 6 xmlSecAppVerifyFile [xmlsec\apps\xmlsec.c:1324] Note: # 7 main [xmlsec\apps\xmlsec.c:1091] Note: instruction: cmp (%eax) $0x00000018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And a not implemented error.