configure: macOS improvement #197
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the case when the issuer certificate is not trusted, parents are not in the trusted store, but we can find a parent in the untrusted store which has a parent in the trusted store. Testcase: XMLSEC_TEST_NAME="merlin-xmldsig-twenty-three/signature" nmake check-dsig
Testcase: XMLSEC_TEST_NAME="signature-big" nmake check-dsig
See <https://lists.gnu.org/archive/html/libtool/2010-04/msg00020.html>, shrext_cmds is a command to be evaluated. Linux uses .so for both loadable and shared libraries (in terms of libtool), so the problem is not visible there, but on macOS this caused configure to literally look for libnspr4`test .$module = .yes && echo .so || echo .dylib` for the nss backend, while nss provides libnspr4.dylib.
lsh123
approved these changes
Jun 25, 2018
| if(ret < 0) { | ||
| xmlSecInternalError("xmlSecMSCngKeyDataX509AdoptKeyCert", | ||
| xmlSecKeyDataGetName(x509Data)); | ||
| CertFreeCertificateContext(tmpcert); |
There was a problem hiding this comment.
You don't need to do it since it is free'd in the done block
There was a problem hiding this comment.
Thanks for spotting, I'll fix that later in a follow-up PR. And sorry, I forgot to rebase, these two mscng commits were already merged in a previous PR, so they were not meant to be included here. (Though the squash merge did the right thing.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seems this worked only by accident on Linux so far.