build: Increase minimal version numbers for NSPR/NSS #263
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please do not merge yet, as I am unsure about the minimal XULRunner version. |
Currently, xmlsec detects the header files from an ancient XULRunner 1.19.6 installation [1]. Increase the version numbers, so commit 419ba213 (Bug 356713: Add the OID for SHA-224.) for `SEC_OID_SHA224` (NSS 3.13) and commit 75af8ccb (Bug 475578 - Implement Extended DSA as defined in FIPS 186-3 (DSS)) for `SEC_OID_NIST_DSA_SIGNATURE_WITH_SHA256_DIGEST` (NSS 3.14) [2] are included. [1]: https://bugs.documentfoundation.org/show_bug.cgi?id=124910 [2]: nss-dev/nss@419ba21 [3]: nss-dev/nss@75af8cc
paulmenzel
force-pushed
the
increase-minimal-nspr-nss-versions
branch
from
b9584a7 to
a539a3a
Compare
|
I actually much prefer your other patch that changes the lookup order. I think it is cleaner than mocking with versions (that might change in the future). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.