win32: fix undeclared XMLSEC_DEFAULT_CRYPTO #37
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The problem was that APP_CFLAGS is not used for src/xmlsec.c, but it now uses the identifier. This wasn't a problem on Linux, where commit 29da6cb (replace XMLSEC_CRYPTO define with xmlSecGetDefaultCrypto() function, 2016-02-06) updated src/Makefile.am to include XMLSEC_DEFAULT_CRYPTO in the generic AM_CFLAGS.
|
Thank you! Good catch! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem was that APP_CFLAGS is not used for src/xmlsec.c, but it now
uses the identifier. This wasn't a problem on Linux, where commit
29da6cb (replace XMLSEC_CRYPTO define
with xmlSecGetDefaultCrypto() function, 2016-02-06) updated
src/Makefile.am to include XMLSEC_DEFAULT_CRYPTO in the generic
AM_CFLAGS.
Full build LibreOffice log, showing the failure without the patch:
http://ci.libreoffice.org/job/lo_gerrit_master/18553/Gerrit=Gerrit,Platform=Windows/console