New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mscrypto: fix XMLSEC_KEYINFO_FLAGS_X509DATA_DONT_VERIFY_CERTS handling #79

Merged
merged 1 commit into from Jan 29, 2017

Conversation

Projects
None yet
2 participants
@vmiklos
Contributor

vmiklos commented Jan 28, 2017

Always extract it, just don't construct the certificate chain if the
flag is used.

With this, the recently added two new testcases in commits
7f6f993 (nss: fix
XMLSEC_KEYINFO_FLAGS_X509DATA_DONT_VERIFY_CERTS handling (#78),
2017-01-22) and 1533729 (nss adopt cert
type (#73), 2016-12-15) also pass for mscrypto.

@vmiklos

This comment has been minimized.

Show comment
Hide comment
@vmiklos

vmiklos Jan 28, 2017

Contributor

Oops, actually the second commit is not relevant, that one already passed before this commit. I'll update the commit message.

Contributor

vmiklos commented Jan 28, 2017

Oops, actually the second commit is not relevant, that one already passed before this commit. I'll update the commit message.

mscrypto: fix XMLSEC_KEYINFO_FLAGS_X509DATA_DONT_VERIFY_CERTS handling
Always extract it, just don't construct the certificate chain if the
flag is used.

With this, the recently added new testcase from commit
7f6f993 (nss: fix
XMLSEC_KEYINFO_FLAGS_X509DATA_DONT_VERIFY_CERTS handling (#78),
2017-01-22) passes also for mscrypto.

@lsh123 lsh123 merged commit 1f5779a into lsh123:master Jan 29, 2017

@vmiklos vmiklos deleted the vmiklos:fix-mscrypto-noverify branch Feb 18, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment