nss: add ECDSA-SHA256 support #83
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lsh123
reviewed
Feb 18, 2017
src/nss/signatures.c
Outdated
| xmlSecTransformGetName(transform)); | ||
| return(-1); | ||
| if(ctx->alg == SEC_OID_ANSIX9_DSA_SIGNATURE_WITH_SHA1_DIGEST) { | ||
| statusDer = DSAU_EncodeDerSig(&signatureDer, &signature); |
There was a problem hiding this comment.
Is it possible to use DSAU_EncodeDerSigWithLen() for SHA1 too?
There was a problem hiding this comment.
Indeed, the difference between the two is just an assert before they call a shared internal function, so using DSAU_EncodeDerSigWithLen() for both makes sense.
make check-crypto-nss XMLSEC_TEST_NAME="aleksey-xmldsig-01/enveloping-sha256-ecdsa-sha256" now passes after these changes. Other notes: - the NSS representation of ECDSA keys is ecKey - the NSS identifier for ECDSA-SHA256 is SEC_OID_ANSIX962_ECDSA_SHA256_SIGNATURE - ECDSA has no fixed signature size, as it depends on the curve parameters. This means the size has to be always told explicitly to NSS, so DSAU_DecodeDerSig() -> DSAU_DecodeDerSigToLen(), DSAU_EncodeDerSig() -> DSAU_EncodeDerSigWithLen(). - the full list of supported ECDSA parameters is at e.g. NSS ecdecode.c, EC_FillParams(): https://dxr.mozilla.org/nss/source/nss/lib/freebl/ecdecode.c#214 - ECDSA support is available in 3.11.1 according to <https://wiki.mozilla.org/NSS:Roadmap:Archive#Elliptic_Curve_Cryptography>, so upgrade the minimal version requirement accordingly.
|
https://wiki.mozilla.org/NSS:Roadmap:Archive#Elliptic_Curve_Cryptography says 3.11.1 should be the new requirement, hopefully that's not really problematic, I have 3.28 e.g. here. |
vmiklos
force-pushed
the
nss-ecdsa-sha256
branch
from
13a5250 to
1650d8d
Compare
|
Hi, Can I help anything to get this reviewed? :-) Thanks, Miklos |
|
Apologies, I thought I already merged it :) |
vmiklos
pushed a commit
to vmiklos/xmlsec
that referenced
this pull request
Mar 6, 2017
Conflicts: configure.ac src/nss/signatures.c
vmiklos
pushed a commit
to vmiklos/xmlsec
that referenced
this pull request
Apr 20, 2017
Conflicts: configure.ac src/nss/signatures.c
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
make check-crypto-nss XMLSEC_TEST_NAME="aleksey-xmldsig-01/enveloping-sha256-ecdsa-sha256"
now passes after these changes. Other notes:
the NSS representation of ECDSA keys is ecKey
the NSS identifier for ECDSA-SHA256 is
SEC_OID_ANSIX962_ECDSA_SHA256_SIGNATURE
ECDSA has no fixed signature size, as it depends on the curve
parameters. This means the size has to be always told explicitly to
NSS, so DSAU_DecodeDerSig() -> DSAU_DecodeDerSigToLen(),
DSAU_EncodeDerSig() -> DSAU_EncodeDerSigWithLen().
the full list of supported ECDSA parameters is at e.g. NSS ecdecode.c,
EC_FillParams():
https://dxr.mozilla.org/nss/source/nss/lib/freebl/ecdecode.c#214