Leaking file descriptors for 1.4.4 branch #163

Closed
wants to merge 15 commits into
from

2 participants

@auidah

Fix the leaking file descriptor bug for the stable 1.4.4 fork of Diffa only, incorporating no other changes.

File descriptors were being held onto by both IndexWriters and IndexReaders, so these both need to be closed intermittently. For now, an interval of once every 100 change events seems not to impact performance unreasonably - it can be reconfigured with a reboot if necessary (no code change required).

auidah and others added some commits May 15, 2012
@auidah auidah Created release notes for 1.4.4.1.
Merged refactoring of test with timing issue from main line for consistency.
13cd72f
Anthony Up'd version from 1.4.4 to 1.4.4.1. c80c89b
@auidah auidah Cleanup unused imports. 0399ac1
@auidah auidah Should use openWriter instead of writer directly; otherwise any mocki…
…ng will not really inject.
daead45
@auidah auidah Changed IndexWriter close condition from being time-based to action-c…
…ount based.

Conflicts:

	kernel/src/main/scala/net/lshift/diffa/kernel/actors/PairActorSupervisor.scala
	kernel/src/test/scala/net/lshift/diffa/kernel/actors/PairActorTest.scala
c0f4307
@auidah auidah Added injection of a default diffa.lucene.close.interval value into P…
…airActorSupervisor.
9ebcb8f
@auidah auidah made indenting consistent. 8c5e8ab
@auidah auidah Clean up of unused imports.
Conflicts:

	kernel/src/main/scala/net/lshift/diffa/kernel/actors/PairActor.scala
	kernel/src/test/scala/net/lshift/diffa/kernel/actors/PairActorTest.scala
5486f8f
@auidah auidah Import tidy up. 32e7546
@auidah auidah Corrected the issue number and description for 151. 70c9332
@auidah auidah Removed unused object.
Made timeSince more obvious.
2b75b0d
@auidah auidah Tidied up test execution: tests were passing but reporting spurious w…
…arnings.
79697b9
@auidah auidah Modified to verify that both the IndexWriter and any associated Index…
…Readers are closed upon LuceneWriter.close.
72ffe46
@auidah auidah Encapsulated the actions involved in creating an IndexWriter to ensur…
…e that state variables are consistent.
571f24a
@auidah auidah Corrected dependency on hibernate-migrations from 1.4.4 to 1.4.4.1. 6414200
@0x6e6562

Whilst this cannot be merged into the mainline (since it has moved on since the point that this fork is based on), this patch is fine and represents a proper backport of #149.

@0x6e6562 0x6e6562 closed this May 24, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment