Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP
branch: master
Commits on Apr 5, 2012
  1. @fabpot

    merged branch lennerd/error-1 (PR #113)

    fabpot authored
    Commits
    -------
    
    da92d88 ManagerRegistry returns the default Manager when the name is null
    
    Discussion
    ----------
    
    ManagerRegistry returns the default Manager when the name is null
    
    Fixes the failing tests caused by the changed way of getting the default Manager.
Commits on Apr 4, 2012
  1. @lennerd
Commits on Mar 28, 2012
  1. @fabpot

    merged branch KingCrunch/master (PR #107)

    fabpot authored
    Commits
    -------
    
    f56f4ec "Cache"-Annotation accepts "Vary"-header
    
    Discussion
    ----------
    
    Support for "Vary"-headers in "Cache" annotation
    
    Just allows to use `vary` in the Cache annotation
    
         * @Cache(maxage="86400",smaxage="21600",vary={"Cookie"})
    
    ---------------------------------------------------------------------------
    
    by fabpot at 2012-03-23T12:19:14Z
    
    Can you also update the documentation which is within this bundle? Thanks.
    
    ---------------------------------------------------------------------------
    
    by KingCrunch at 2012-03-28T06:48:19Z
    
    Changed the doc for a while now (was a one liner). Maybe I shouldn't have squashed both changes together into one commit?
    
    ---------------------------------------------------------------------------
    
    by stof at 2012-03-28T11:23:57Z
    
    @KingCrunch the missing point was probably the comment to notify that the update was done :)
Commits on Mar 26, 2012
  1. @fabpot

    merged branch hhamon/documentation_fixes (PR #110)

    fabpot authored
    Commits
    -------
    
    f392b38 [Resources] fixed @Template() annotation documentation. Fixes #102.
    
    Discussion
    ----------
    
    [Resources] fixed @Template() annotation documentation. Fixes #102.
  2. @hhamon
Commits on Mar 23, 2012
  1. @KingCrunch
Commits on Mar 18, 2012
  1. @fabpot

    merged branch olegstepura/patch-1 (PR #104)

    fabpot authored
    Commits
    -------
    
    804f63f Use single variable for reflection class instance
    7a0c7c0 Make Template guesser look at parent classes for bundle
    
    Discussion
    ----------
    
    Make Template guesser look at parent classes for bundle (The better way)
    
    Solves the same issue as this pull request: #98
    
    but is a better way to do that - inside getBundleForClass() method and without catching exceptions (which must be slower and would be the default behavior for all secured via annotations controllers with the latest JMSSecurityExtraBundle)
    
    ---------------------------------------------------------------------------
    
    by olegstepura at 2012-03-08T22:28:31Z
    
    Fixes symfony/symfony-standard#285 after applying symfony/symfony-standard#275
  2. @fabpot

    merged branch henrikbjorn/security-extra (PR #84)

    fabpot authored
    Commits
    -------
    
    22b20e6 Fix template guessing when CGLibrary is used fixes #83
    
    Discussion
    ----------
    
    Fix template guessing when CGLibrary is used fixes #83
    
    ---------------------------------------------------------------------------
    
    by jacobmaster at 2012-01-16T11:08:30Z
    
    When can we expect new version with update?
    
    ---------------------------------------------------------------------------
    
    by dustinwhittle at 2012-03-03T13:43:45Z
    
    Any update?
  3. @fabpot

    merged branch ricardclau/master (PR #106)

    fabpot authored
    Commits
    -------
    
    c0035ab fixing @Cache reading at class level and some tests
    
    Discussion
    ----------
    
    Fix Cache annotation when set at Class level fixes #66
    
    Cache annotation is ignored when it is set at class level, this patch makes Cache annotations work at class level and if there is a Cache annotation at method level, it overrides class configuration.
    
    Unit tests are added, with 3 fixture controllers with @Cache annotations both at class and method level
  4. @ricardclau
Commits on Mar 8, 2012
  1. Use single variable for reflection class instance

    Oleg Stepura authored
Commits on Mar 3, 2012
  1. @fabpot

    merged branch jvandenenden/patch-1 (PR #101)

    fabpot authored
    Commits
    -------
    
    bc901e1 The property streamable on line 67 is not found, resulting in an error. The property isStreamable is renamed to streamable in order to solve this problem.
    
    Discussion
    ----------
    
    Invalid property isStreamable in Template class
    
    The property streamable on line 67 does not exist, resulting in an error when calling the function. The property isStreamable is renamed to streamable in order to solve this problem.
  2. The property streamable on line 67 is not found, resulting in an erro…

    jvandenenden authored
    …r. The property isStreamable is renamed to streamable in order to solve this problem.
Commits on Mar 2, 2012
  1. @fabpot

    fixed typo

    fabpot authored
  2. @fabpot

    merged branch mjakubowski/patch-1 (PR #75)

    fabpot authored
    Commits
    -------
    
    034dbee Added documentation on how to use the controller as a service
    
    Discussion
    ----------
    
    Added documentation on how to use the controller as a service
    
    Found out by the code how this should work, so it would be nice if it was included in the documentation.
    
    ---------------------------------------------------------------------------
    
    by fabpot at 2011-11-24T13:14:57Z
    
    Can you rebase your PR on the 2.0 branch? Thanks.
  3. @fabpot

    merged branch henrikbjorn/streamable-template (PR #86)

    fabpot authored
    Commits
    -------
    
    21290a3 fix typo
    06ceb81 StreamedResponse
    
    Discussion
    ----------
    
    StreamedResponse
    
    ---------------------------------------------------------------------------
    
    by henrikbjorn at 2011-12-22T20:10:06Z
    
    fixes #85
Commits on Jan 28, 2012
  1. @fabpot

    fixed phpdoc

    fabpot authored
Commits on Jan 11, 2012
  1. @fabpot

    merged branch jakzal/TypoFix (PR #93)

    fabpot authored
    Commits
    -------
    
    ab1c429 Fixed class name in the documentation (DoctrineConverter -> DoctrineParamConverter).
    
    Discussion
    ----------
    
    Fixed class name in the documentation
    
    DoctrineConverter -> DoctrineParamConverter
  2. @fabpot

    Merge branch '2.0'

    fabpot authored
    * 2.0:
      Changed the default value for the entity manager name
  3. @fabpot

    merged branch Yrch/2.0 (PR #94)

    fabpot authored
    Commits
    -------
    
    07c2032 Changed the default value for the entity manager name
    
    Discussion
    ----------
    
    Changed the default value for the entity manager name
    
    Using null fetches the default entity manager from the registry (which always
    exists when the ORM is configured) whereas using 'default' fetches the entity
    manager named 'default' (which exists when using the short notation because
    it is the name used in this case but is not enforced)
    
    ---------------------------------------------------------------------------
    
    by stof at 2012-01-10T21:59:57Z
    
    @fabpot ping
    
    This caused some issues for someone using a different name for his default manager.
Commits on Jan 6, 2012
  1. @stof

    Changed the default value for the entity manager name

    stof authored
    Using null fetches the default entity manager from the registry (which always
    exists when the ORM is configured) whereas using 'default' fetches the entity
    manager named 'default' (which exists when using the short notation because
    it is the name used in this case but is not enforced)
  2. @jakzal
Commits on Dec 22, 2011
  1. @henrikbjorn

    fix typo

    henrikbjorn authored
  2. @henrikbjorn

    StreamedResponse

    henrikbjorn authored
Commits on Dec 16, 2011
  1. @henrikbjorn
Commits on Dec 14, 2011
  1. @fabpot

    merged branch henrikbjorn/already-converted-values (PR #81)

    fabpot authored
    Commits
    -------
    
    bc0ec33 change is_a to instanceof
    3eda845 ParamConverterManager now checks if the value is the correct instance.
    
    Discussion
    ----------
    
    ParamConverterManager now checks if the value is the correct instance.
    
    This is needed because:
        {% render 'MyVenBundle:Controller:Action', { 'entity' : entity } %}
    
    would pass an already converted value.
    
    ---------------------------------------------------------------------------
    
    by henrikbjorn at 2011/12/14 00:12:32 -0800
    
    note: is_a accepts strings from 5.3.7 but passing strings is considered a security bug and because of that there is a check with is_object.
  2. @henrikbjorn

    change is_a to instanceof

    henrikbjorn authored
  3. @henrikbjorn

    ParamConverterManager now checks if the value is the correct instance.

    henrikbjorn authored
    This is needed because:
        {% render 'MyVenBundle:Controller:Action', { 'entity' : entity } %}
    
    would pass an already converted value.
Commits on Dec 13, 2011
  1. @fabpot

    merged branch lenar/template-guesser (PR #78)

    fabpot authored
    Commits
    -------
    
    929e093 Add template name guesser service (with suggested changes)
    
    Discussion
    ----------
    
    Add template name guesser service
    
    This change would help @schmittjoh's override of template name guessing in [JMSDiExtraBundle](/schmittjoh/JMSDiExtraBundle)  to be implemented in a way that does not disrupt [FOSRestBundle](/FriendsOfSymfony/FOSRestBundle) as described in schmittjoh/JMSDiExtraBundle#14.
    
    ---------------------------------------------------------------------------
    
    by lenar at 2011/11/30 05:01:44 -0800
    
    I implemented your suggestions. And added the changes to existing files I somehow managed to not-commit before.
    
    ---------------------------------------------------------------------------
    
    by stof at 2011/11/30 05:06:57 -0800
    
    This template guesser is used nowhere so it seems like part of your patch is missing
    
    ---------------------------------------------------------------------------
    
    by lenar at 2011/11/30 05:13:43 -0800
    
    @stof, @henrikbjorn: Sorry I messed up the commits multiple times. It seems my mind has been taken over by the "demons" of hg.
    
    I've implemented the changes suggested so far and added the changes that were missing. Made a clean push to branch.
    
    Really, sorry for the inconveniences.
Commits on Nov 30, 2011
  1. @lenar
Commits on Nov 25, 2011
  1. @fabpot

    added a CHANGELOG

    fabpot authored
  2. @fabpot

    merged branch henrikbjorn/parameter-name-bug (PR #56)

    fabpot authored
    Commits
    -------
    
    22c69c0 Cleanup
    76c521f Change apply method to always return a boolean value. This makes converting attributes with the name name as a action parameter possible
    
    Discussion
    ----------
    
    Change apply method to always return a boolean value. This makes converti
    
    Change apply method to always return a boolean value. This makes converting attributes with the name name as a action parameter possible.
    
    symfony/symfony#1547 (comment)
    
    Before this patch it was not possible to have a /blog/archive/{date} route and a action like `myAction(DateTime $date)` as the request attribute would already exists and the paramconverter would not be called.
    
    This path is breaking BC for the apply method on ParamConverterInterface which now MUST return a boolean value indicating if a conversion was done.
    
    ---------------------------------------------------------------------------
    
    by fabpot at 2011/08/23 02:43:57 -0700
    
    The semantic of the converters is also changed with this patch. Currently, we only convert parameters that are not yet in the attributes. After the patch, you convert all parameters even if they are already in the request attributes.
    
    ---------------------------------------------------------------------------
    
    by henrikbjorn at 2011/08/23 03:50:06 -0700
    
    The problem with having to abort the parameter conversion when the attribute is already there is if you give a route a default it will already be present and not converted.
    
    ---------------------------------------------------------------------------
    
    by henrikbjorn at 2011/08/23 03:50:59 -0700
    
    And the conversion of a parameter is aborted if a converter returns true, the converter should be able to handle default parameters :)
    
    ---------------------------------------------------------------------------
    
    by henrikbjorn at 2011/08/29 06:44:03 -0700
    
    As you might want to load a default category object if no specific category was provided.
    
    ---------------------------------------------------------------------------
    
    by henrikbjorn at 2011/11/25 08:15:11 -0800
    
    @fabpot rebased and tests pass :) good to go.
  3. @henrikbjorn

    Cleanup

    henrikbjorn authored henrikbjorn committed
  4. @henrikbjorn

    Change apply method to always return a boolean value. This makes conv…

    henrikbjorn authored henrikbjorn committed
    …erting attributes with the name name as a action parameter possible
Something went wrong with that request. Please try again.