Permalink
Commits on Oct 9, 2011
  1. cosmetic tweak

    lsmith77 committed Oct 9, 2011
  2. merged branch ioalessio/2.0 (PR #2363)

    fabpot committed Oct 9, 2011
    Commits
    -------
    
    dd0d6fd fixing italian messages
    
    Discussion
    ----------
    
    italian messages
    
    "bug fix" for branch 2.0
Commits on Oct 8, 2011
  1. fixing italian messages

    ioalessio committed Oct 8, 2011
  2. First

    azatyan authored and fabpot committed Oct 8, 2011
  3. merged branch craue/patch-14 (PR #2354)

    fabpot committed Oct 8, 2011
    Commits
    -------
    
    2e5869d fixed "using $this when not in object context" error for 2.0 branch (replaces #2353)
    
    Discussion
    ----------
    
    fixed "using $this when not in object context" error for 2.0 branch (replaces #2353)
  4. merged branch stealth35/fix_distant_trans (PR #2346)

    fabpot committed Oct 8, 2011
    Commits
    -------
    
    ae0685a [Translation] Loader should only load local files
    
    Discussion
    ----------
    
    [Translation] Security : Loader should only load local files
    
    Bug fix: no
    Feature addition: no
    Backwards compatibility break: no
    Symfony2 tests pass: yes
    Fixes the following tickets: -
    See: #2327
Commits on Oct 7, 2011
  1. merged branch stloyd/form_texttypes (PR #2343)

    fabpot committed Oct 7, 2011
    Commits
    -------
    
    8bd0e42 [Form] Use proper parent (text) for EmailType and TextareaType
    
    Discussion
    ----------
    
    [2.0][Form] Use proper parent (text) for EmailType and TextareaType
    
    Bug fix: yes
    Feature addition: no
    Backwards compatibility break: no
    Symfony2 tests pass: yes
    Fixes the following tickets: -
  2. merged branch stloyd/ScalarTransformer (PR #2341)

    fabpot committed Oct 7, 2011
    Commits
    -------
    
    95049ef [Form] Added type check to `ScalarToChoiceTransformer`
    
    Discussion
    ----------
    
    [2.0][Form] Added type check to ScalarToChoiceTransformer
    
    Bug fix: yes
    Feature addition: no
    Backwards compatibility break: no
    Symfony2 tests pass: yes
    Fixes the following tickets: -
  3. merged branch stloyd/FormUtil (PR #2340)

    fabpot committed Oct 7, 2011
    Commits
    -------
    
    18a83c6 [Form] Simplified a bit `FormUtil` and extended test coverage
    
    Discussion
    ----------
    
    [2.0][Form] Simplified a bit `FormUtil` and extended test coverage
    
    Bug fix: no
    Feature addition: no
    Backwards compatibility break: no
    Symfony2 tests pass: yes
    Fixes the following tickets: -
  4. merged branch stloyd/date_time_validator_tests (PR #2338)

    fabpot committed Oct 7, 2011
    Commits
    -------
    
    d7c9644 [Validator] Extend and fix DateValidator & TimeValidator tests
    
    Discussion
    ----------
    
    [2.0][Validator] Extend and fix DateValidator & TimeValidator tests
    
    Bug fix: no
    Feature addition: no
    Backwards compatibility break: no
    Symfony2 tests pass: yes
    Fixes the following tickets: -
Commits on Oct 6, 2011
Commits on Oct 5, 2011
  1. merged branch fivestar/fix-form-datetime-2_0 (PR #2326)

    fabpot committed Oct 5, 2011
    Commits
    -------
    
    828b18f [Form] Fixed lacking attributes in DateTimeType
    
    Discussion
    ----------
    
    [Form] Fixed lacking attributes in DateTimeType
    
    Added invalid_message and invalid_message_parameters. (Moved from #2311)
Commits on Oct 4, 2011
  1. updated VERSION for 2.0.4

    fabpot committed Oct 4, 2011
  2. update CONTRIBUTORS for 2.0.4

    fabpot committed Oct 4, 2011
  3. updated CHANGELOG for 2.0.4

    fabpot committed Oct 4, 2011
  4. updated vendors for 2.0.4

    fabpot committed Oct 4, 2011
Commits on Oct 3, 2011
  1. merged branch dpb587/patch-appkern (PR #2312)

    fabpot committed Oct 3, 2011
    Commits
    -------
    
    5419638 [HttpKernel] Show the actual directory needing to be created.
    
    Discussion
    ----------
    
    [HttpKernel] Show the actual directory needing to be created.
    
    Bug fix: yes
    Feature addition: no
    Backwards compatibility break: no
    Symfony2 tests pass: yes
    Fixes the following tickets: -
    
    before: Unable to create the logs directory (/home/symfony/root/app)
    after: Unable to create the logs directory (/home/symfony/root/app/logs)
Commits on Sep 30, 2011
  1. merged branch Gregwar/proxy_file_issue (PR #1968)

    fabpot committed Sep 30, 2011
    Commits
    -------
    
    0e00e3f [DoctrineBundle] CS
    0c4b793 [DoctrineBundle] Fixed performances issues on "On-demand" proxy file generation
    e866a67 [DoctrineBundle] Tries to auto-generate the missing proxy files on the autoloader
    
    Discussion
    ----------
    
    [DoctrineBundle] Tries to auto-generate the missing proxy files on the autoloaded
    
    See:
    symfony#1965
    symfony#1535
    
    This fix is not really clean and there's maybe a factorizing work to do on it, but this work and avoid me spending my day deleting session cookies each time I clear cache.
    
    ---------------------------------------------------------------------------
    
    by stloyd at 2011/08/23 10:37:28 -0700
    
    You should follow Symfony2 CS (http://symfony.com/doc/current/contributing/code/standards.html).
    
    ---------------------------------------------------------------------------
    
    by ruudk at 2011/09/26 02:50:13 -0700
    
    +1
    
    ---------------------------------------------------------------------------
    
    by fabpot at 2011/09/27 07:01:51 -0700
    
    It looks like a bug fix, so this PR should be closed and a new one based on the 2.0 branch should be open. @beberlei: are you fine with this patch?
    
    ---------------------------------------------------------------------------
    
    by beberlei at 2011/09/29 04:24:22 -0700
    
    What is this for? I dont understand the bug and the solution here screams cache slam.
    
    ---------------------------------------------------------------------------
    
    by beberlei at 2011/09/29 04:34:02 -0700
    
    Ok i get the problem but the solution is still a monsterous hack. Can we find a real solution to the problem? There has to be one.
    
    ---------------------------------------------------------------------------
    
    by Gregwar at 2011/09/29 04:34:25 -0700
    
    @beberlei, when an user is authenticated for instance, there can be proxies serialized in session.
    
    Si if you clear the cache in dev environment you'll get an error because the matching proxy classes won't exist and you'll be forced to clear your cookies and reauth, which can be annoying
    
    ---------------------------------------------------------------------------
    
    by Gregwar at 2011/09/29 04:38:45 -0700
    
    @beberlei, yes, I agree that we should do something more elegant, but the problem is that when PHP "meet" the proxy class we can't really know what was the "original" class it is supposed to extend
    
    And as @schmittjoh said, this will only be executed very rarely
    
    ---------------------------------------------------------------------------
    
    by beberlei at 2011/09/29 05:18:35 -0700
    
    You agree you want something more suitable and still want this to be merged?
    
    To ease the immediate pain wr could allow this however only in debug mode. A real solution here is maybe to move the proxy files out of the env folders. Rhey dont depend ont the env after all.
    
    ---------------------------------------------------------------------------
    
    by stloyd at 2011/09/29 05:21:33 -0700
    
    Proxy is not depending on env, but generation of proxy is... So this solution will be hard IMO, or even unacceptable...
    
    ---------------------------------------------------------------------------
    
    by Gregwar at 2011/09/29 05:25:39 -0700
    
    @beberlei what I meant is that I agree that's dirty but I don't think of anything better to solve this...
    
    ---------------------------------------------------------------------------
    
    by fabpot at 2011/09/29 06:23:03 -0700
    
    Even if the current patch is not the best solution, we should probably apply it to fix the problem and think about a better solution afterwards. Does it sound good for everybody?
  2. merged branch dpb587/patch-monoweb (PR #2296)

    fabpot committed Sep 30, 2011
    Commits
    -------
    
    e70c884 [Bridge/Monolog] Fix WebProcessor to accept a Request object.
    
    Discussion
    ----------
    
    [Bridge/Monolog] Fix WebProcessor to accept a Request object.
    
    WebProcessor.php is type hinting a bad interface. Adds a simple test case.
    
    Bug fix: yes
    Feature addition: no
    Backwards compatibility break: no
    Symfony2 tests pass: yes
    Fixes the following tickets: -
    
    Before:
    
        1) Symfony\Tests\Bridge\Monolog\Processor\WebProcessorTest::testUsesRequestServerData
        Argument 1 passed to Symfony\Bridge\Monolog\Processor\WebProcessor::__construct() must be an instance of Symfony\Bridge\Monolog\Processor\RequestInterface, instance of Symfony\Component\HttpFoundation\Request given, called in ./symfony/vendor/symfony/tests/Symfony/Tests/Bridge/Monolog/Processor/WebProcessorTest.php on line 31 and defined
    
        ./symfony/vendor/symfony/src/Symfony/Bridge/Monolog/Processor/WebProcessor.php:24
        ./symfony/vendor/symfony/tests/Symfony/Tests/Bridge/Monolog/Processor/WebProcessorTest.php:31
    
        FAILURES!
        Tests: 1, Assertions: 0, Errors: 1.
    
    After:
    
        Starting test 'Symfony\Tests\Bridge\Monolog\Processor\WebProcessorTest::testUsesRequestServerData'.
        OK (1 test, 3 assertions)
    
    Global:
    
        OK, but incomplete or skipped tests!
        Tests: 4337, Assertions: 10590, Incomplete: 36, Skipped: 23.