Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify the SomeBV implementations #174

Merged
merged 4 commits into from
Feb 19, 2024
Merged

Unify the SomeBV implementations #174

merged 4 commits into from
Feb 19, 2024

Conversation

lsrcz
Copy link
Owner

@lsrcz lsrcz commented Feb 19, 2024

This pull request unifies all the SomeIntN, SomeWordN, SomeSymIntN, SomeSymWordN implementations with a single SomeBV type.

These legacy types are now type and pattern synonyms.

Copy link

codecov bot commented Feb 19, 2024

Codecov Report

Attention: 141 lines in your changes are missing coverage. Please review.

Comparison is base (4e3d175) 54.52% compared to head (217ee63) 57.22%.

Files Patch % Lines
src/Grisette/Core/Data/SomeBV.hs 36.48% 101 Missing and 40 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #174      +/-   ##
==========================================
+ Coverage   54.52%   57.22%   +2.69%     
==========================================
  Files          69       70       +1     
  Lines        5786     5641     -145     
  Branches      446      460      +14     
==========================================
+ Hits         3155     3228      +73     
+ Misses       2185     1953     -232     
- Partials      446      460      +14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lsrcz lsrcz merged commit e82c2d0 into main Feb 19, 2024
19 of 20 checks passed
@lsrcz lsrcz deleted the unify-somebv branch February 19, 2024 02:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant