Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change to use Int instead of Natural for SomeBV creations #179

Merged
merged 2 commits into from
Feb 28, 2024

Conversation

lsrcz
Copy link
Owner

@lsrcz lsrcz commented Feb 28, 2024

In #174, we introduced the unified SomeBV implementation and provided its creation with a run-time bit width. The run-time bit width was particularly hard to use in my experience.

This pull request changed it to use Int.

Copy link

codecov bot commented Feb 28, 2024

Codecov Report

Attention: Patch coverage is 15.38462% with 11 lines in your changes are missing coverage. Please review.

Project coverage is 58.56%. Comparing base (f813166) to head (767d234).

Files Patch % Lines
src/Grisette/Core/Data/SomeBV.hs 15.38% 1 Missing and 10 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #179      +/-   ##
==========================================
- Coverage   58.57%   58.56%   -0.02%     
==========================================
  Files          70       70              
  Lines        5813     5816       +3     
  Branches      485      486       +1     
==========================================
+ Hits         3405     3406       +1     
- Misses       1923     1924       +1     
- Partials      485      486       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lsrcz lsrcz merged commit 283d1c6 into main Feb 28, 2024
18 of 20 checks passed
@lsrcz lsrcz deleted the use-int-instead-of-natural-for-somebv branch February 28, 2024 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant