Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow equality test for SomeBV with different bit widths #200

Merged
merged 1 commit into from
May 2, 2024

Conversation

lsrcz
Copy link
Owner

@lsrcz lsrcz commented May 2, 2024

The equality testing for SomeBV will now return false instead of throwing an exception when the bit widths are different.

This is

  • well defined, and
  • very commonly used.

Other binary operators will continue to throw an BitwidthMismatch exception when the bit widths does not match.

…rowing an exception when the bit widths are different
Copy link

codecov bot commented May 2, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 58.93%. Comparing base (71a5fce) to head (efc310a).

Files Patch % Lines
src/Grisette/Internal/SymPrim/SomeBV.hs 75.00% 0 Missing and 4 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #200      +/-   ##
==========================================
+ Coverage   58.87%   58.93%   +0.05%     
==========================================
  Files          78       78              
  Lines        6551     6563      +12     
  Branches      626      630       +4     
==========================================
+ Hits         3857     3868      +11     
+ Misses       2068     2065       -3     
- Partials      626      630       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lsrcz lsrcz merged commit fa019f7 into main May 2, 2024
20 checks passed
@lsrcz lsrcz deleted the equality-for-somebv branch May 2, 2024 00:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant