DM-23343: Add procedure for deprecating packages #395
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdswinbank
force-pushed
the
tickets/DM-23343
branch
from
f4d6829
to
ff0a516
Compare
ktlim
reviewed
May 6, 2020
stack/deprecating-interfaces.rst
Outdated
|
|
||
| import warnings | ||
|
|
||
| warnings.warn('lsst.example.package is deprecated, and will be removed from the Rubin Observatory' |
There was a problem hiding this comment.
No comma here since there's no second subject. Real warnings might give a reason and a replacement, but it's OK not to have them for the example.
There was a problem hiding this comment.
If a package does not already have a top-level __init__.py, I guess one would have to be created. This shouldn't happen for stack packages that have to import from .version, but it might happen for others.
ktlim
approved these changes
May 6, 2020
jdswinbank
force-pushed
the
tickets/DM-23343
branch
from
ff0a516
to
3d83c63
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.