Skip to content

Conversation

@hsinfang
Copy link
Collaborator

No description provided.

Copy link
Member

@kfindeisen kfindeisen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but I'd prefer explicitly saying this is a temporary change, just in case somebody looks.

isr:
class: lsst.ip.isr.IsrTaskLSST
config:
doBrighterFatter: False
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a comment saying that this will be merged into ap_pipe on... I guess it's still DM-47750?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Adding a comment is a good idea.

Yes I think just using DM-47750 is good enough; no need for more paperwork :p

This commit will be un-done once the config change happens in ap_pipe
and is included in prompt-base.
@hsinfang hsinfang merged commit 63dec9f into main Nov 22, 2024
5 checks passed
@hsinfang hsinfang deleted the tickets/DM-47750 branch November 22, 2024 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants