Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-44444: Update to latest tox-docker #248

Merged
merged 1 commit into from
May 30, 2024
Merged

DM-44444: Update to latest tox-docker #248

merged 1 commit into from
May 30, 2024

Conversation

rra
Copy link
Member

@rra rra commented May 30, 2024

Support the latest tox-docker version and unpin requests, since the incompatibility is now fixed. The latest tox-docker no longer starts Docker images on localhost or with reliable ports, so modify the test setup to use the new tox-docker-exposed environment variables to locate the test PostgreSQL and Redis services.

Support the latest tox-docker version and unpin requests, since the
incompatibility is now fixed. The latest tox-docker no longer starts
Docker images on localhost or with reliable ports, so modify the test
setup to use the new tox-docker-exposed environment variables to
locate the test PostgreSQL and Redis services.
Copy link
Member

@jonathansick jonathansick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks that great. I like having a randomized connection because running multiple projects at once, or doing a local dev server and running unit tests simultaneously is impossible otherwise.

@rra rra merged commit 2786cda into main May 30, 2024
6 checks passed
@rra rra deleted the tickets/DM-44444 branch May 30, 2024 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants