Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fail with helpful output when DM_SQUARE_DEBUG is bogus #81

Merged
merged 5 commits into from Mar 15, 2019

Conversation

Projects
None yet
2 participants
@jhoblitt
Copy link
Member

jhoblitt commented Mar 15, 2019

No description provided.

@jhoblitt jhoblitt requested review from athornton , afausti and jonathansick Mar 15, 2019

@jonathansick

This comment has been minimized.

Copy link
Member

jonathansick commented Mar 15, 2019

=================================== FAILURES ===================================
_________________________________ FLAKE8-check _________________________________
/home/travis/build/lsst-sqre/sqre-codekit/codekit/eups.py:179:18: W605 invalid escape sequence '\d'
=============================== warnings summary ===============================
codekit/eups.py:179
  /home/travis/build/lsst-sqre/sqre-codekit/codekit/eups.py:179: DeprecationWarning: invalid escape sequence \d
    if re.match('\d', eups_tag):
codekit/eups.py::FLAKE8
  :179: DeprecationWarning: invalid escape sequence \d
-- Docs: https://docs.pytest.org/en/latest/warnings.html
=============== 1 failed, 37 passed, 2 warnings in 3.27 seconds ================
The command "python setup.py test" exited with 1.

Make that a raw string and it should work; if re.match(r'\d', eups_tag):

jhoblitt added some commits Mar 15, 2019

@jhoblitt jhoblitt force-pushed the jhoblitt:tickets/DM-15039-DM_SQUARE_DEBUG branch from f4f125e to c5ac156 Mar 15, 2019

@jonathansick
Copy link
Member

jonathansick left a comment

Looks good.

@jhoblitt

This comment has been minimized.

Copy link
Member Author

jhoblitt commented Mar 15, 2019

Very strangely, python setup.py test didn't catch one of the r string issues when run locally but travis did -- already pushed a fix.

@jhoblitt jhoblitt merged commit 9812240 into lsst-sqre:master Mar 15, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@jhoblitt jhoblitt deleted the jhoblitt:tickets/DM-15039-DM_SQUARE_DEBUG branch Mar 15, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.