From fbde98562ba454b7d0396eb5a3794d24a156827f Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Agn=C3=A8s=20Fert=C3=A9?= Date: Fri, 20 Dec 2024 10:14:20 -0800 Subject: [PATCH 1/3] Add Defects focal plot. --- pipelines/cpCore.yaml | 27 ++++++++------------------- 1 file changed, 8 insertions(+), 19 deletions(-) diff --git a/pipelines/cpCore.yaml b/pipelines/cpCore.yaml index 1bfba2fbc..258f344a4 100644 --- a/pipelines/cpCore.yaml +++ b/pipelines/cpCore.yaml @@ -232,25 +232,14 @@ tasks: class: lsst.analysis.tools.tasks.VerifyCalibAnalysisTask config: connections.outputName: cpDefectCore - connections.data: verifyDefectResults - - # TODO: DM-43880 Sort out defects - atools.defectsHotPixels: CalibStatisticFocalPlanePlot - atools.defectsHotPixels.produce.plot.addHistogram: true - atools.defectsHotPixels.produce.plot.zAxisLabel: "Number of Hot Pixels" - atools.defectsHotPixels.quantityKey: DEFECTS_DEFECTS_DIST_N_HOT - atools.defectsHotPixels.unit: "---" - - # atools.defectsColdPixels: CalibStatisticFocalPlanePlot - # atools.defectsColdPixels.produce.plot.addHistogram: true - # atools.defectsColdPixels.produce.plot.zAxisLabel: "Number of Cold Pixels" - # atools.defectsColdPixels.quantityKey: DEFECTS_DEFECTS_DIST_N_COLD - # atools.defectsColdPixels.unit: "---" - # atools.defectsBadColumns: CalibStatisticFocalPlanePlot - # atools.defectsBadColumns.produce.plot.addHistogram: true - # atools.defectsBadColumns.produce.plot.zAxisLabel: "Number of Hot Pixels" - # atools.defectsBadColumns.quantityKey: DEFECTS_DEFECTS_DIST_N_BAD_COLUMNS - # atools.defectsBadColumns.unit: "---" + connections.data: verifyDefectsResults + + atools.defectsPixels: CalibStatisticFocalPlanePlot + atools.defectsPixels.produce.plot.addHistogram: false + # here set name of column from the verify table + atools.defectsPixels.quantityKey: DEFECTS_DEFECT_PIXELS + atools.defectsPixels.unit: pix + python: | from lsst.analysis.tools.atools import * From 32b96c55d7d97116abc78823c7d27441c1a39103 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Agn=C3=A8s=20Fert=C3=A9?= Date: Mon, 31 Mar 2025 10:51:55 -0700 Subject: [PATCH 2/3] From number of pix to percent. --- pipelines/cpCore.yaml | 38 +++++++++++++++++++++++++++++++++++++- 1 file changed, 37 insertions(+), 1 deletion(-) diff --git a/pipelines/cpCore.yaml b/pipelines/cpCore.yaml index 258f344a4..72ad57422 100644 --- a/pipelines/cpCore.yaml +++ b/pipelines/cpCore.yaml @@ -238,7 +238,43 @@ tasks: atools.defectsPixels.produce.plot.addHistogram: false # here set name of column from the verify table atools.defectsPixels.quantityKey: DEFECTS_DEFECT_PIXELS - atools.defectsPixels.unit: pix + atools.defectsPixels.unit: "pix" + + atools.defectsPixelsFrac: CalibStatisticFocalPlanePlot + atools.defectsPixelsFrac.produce.plot.addHistogram: false + atools.defectsPixelsFrac.quantityKey: DEFECTS_FRAC + atools.defectsPixelsFrac.unit: "pix" + + atools.defectsPixelsFracNoEdge: CalibStatisticFocalPlanePlot + atools.defectsPixelsFracNoEdge.produce.plot.addHistogram: false + atools.defectsPixelsFracNoEdge.quantityKey: DEFECTS_FRAC_NOEDGE + atools.defectsPixelsFracNoEdge.unit: "pix" + + atools.defectsPixelsRequirement: CalibStatisticFocalPlanePlot + atools.defectsPixelsRequirement.produce.plot.addHistogram: false + atools.defectsPixelsRequirement.produce.plot.plotMin: 0 + atools.defectsPixelsRequirement.produce.plot.plotMax: 1 + atools.defectsPixelsRequirement.quantityKey: DEFECTS_REQUIREMENT + atools.defectsPixelsRequirement.unit: "---" + + # TODO: DM-43880 Sort out defects + # atools.defectsHotPixels: CalibStatisticFocalPlanePlot + # atools.defectsHotPixels.produce.plot.addHistogram: true + # atools.defectsHotPixels.produce.plot.zAxisLabel: "Number of Hot Pixels" + # atools.defectsHotPixels.quantityKey: DEFECTS_DEFECTS_DIST_N_HOT + # atools.defectsHotPixels.unit: "---" + + # atools.defectsColdPixels: CalibStatisticFocalPlanePlot + # atools.defectsColdPixels.produce.plot.addHistogram: true + # atools.defectsColdPixels.produce.plot.zAxisLabel: "Number of Cold Pixels" + # atools.defectsColdPixels.quantityKey: DEFECTS_DEFECTS_DIST_N_COLD + # atools.defectsColdPixels.unit: "---" + + # atools.defectsBadColumns: CalibStatisticFocalPlanePlot + # atools.defectsBadColumns.produce.plot.addHistogram: true + # atools.defectsBadColumns.produce.plot.zAxisLabel: "Number of Hot Pixels" + # atools.defectsBadColumns.quantityKey: DEFECTS_DEFECTS_DIST_N_BAD_COLUMNS + # atools.defectsBadColumns.unit: "---" python: | from lsst.analysis.tools.atools import * From 051dfdd160a7f23488625c5b67f5ec7826d147a6 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Agn=C3=A8s=20Fert=C3=A9?= Date: Tue, 12 Aug 2025 13:16:15 -0700 Subject: [PATCH 3/3] Update defects focal plane plots. --- pipelines/cpCore.yaml | 15 ++------------- 1 file changed, 2 insertions(+), 13 deletions(-) diff --git a/pipelines/cpCore.yaml b/pipelines/cpCore.yaml index 72ad57422..572ad742f 100644 --- a/pipelines/cpCore.yaml +++ b/pipelines/cpCore.yaml @@ -245,19 +245,8 @@ tasks: atools.defectsPixelsFrac.quantityKey: DEFECTS_FRAC atools.defectsPixelsFrac.unit: "pix" - atools.defectsPixelsFracNoEdge: CalibStatisticFocalPlanePlot - atools.defectsPixelsFracNoEdge.produce.plot.addHistogram: false - atools.defectsPixelsFracNoEdge.quantityKey: DEFECTS_FRAC_NOEDGE - atools.defectsPixelsFracNoEdge.unit: "pix" - - atools.defectsPixelsRequirement: CalibStatisticFocalPlanePlot - atools.defectsPixelsRequirement.produce.plot.addHistogram: false - atools.defectsPixelsRequirement.produce.plot.plotMin: 0 - atools.defectsPixelsRequirement.produce.plot.plotMax: 1 - atools.defectsPixelsRequirement.quantityKey: DEFECTS_REQUIREMENT - atools.defectsPixelsRequirement.unit: "---" - - # TODO: DM-43880 Sort out defects + # TODO: DM-52156 The following will be replaced with statistics for + # different defects reasons # atools.defectsHotPixels: CalibStatisticFocalPlanePlot # atools.defectsHotPixels.produce.plot.addHistogram: true # atools.defectsHotPixels.produce.plot.zAxisLabel: "Number of Hot Pixels"