DM-51670: Update primary flags to use the new deblender model API #450
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fred3m
force-pushed
the
tickets/DM-51670
branch
from
faee58d to
324cd09
Compare
fred3m
force-pushed
the
tickets/DM-51670
branch
from
15c4ae0 to
fae7426
Compare
TallJimbo
approved these changes
Nov 26, 2025
| ) | ||
|
|
||
| if "deblend_nChild" in schema.getNames() or "deblend_scarletFlux" in schema.getNames(): | ||
| if "deblend_nChild" in schema.getNames(): |
Member
There was a problem hiding this comment.
I gather deblend_scarletFlux is still a valid column since it appears elsewhere on this PR; is it just no longer relevant for this logic branch?
Contributor
Author
There was a problem hiding this comment.
Correct. I had added it in one of the intermediate commits because originally I had removed deblend_nChild from the measurement catalog. Once I realized that shapeHSM and possibly other plugins used deblend_nChild I felt like it was easier to leave it in the catalog, especially since that column is in the single visit SourceCatalog as well. So there was no need to add an extra condition.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.