DM-31466: Fix spatialOrder minimum value to avoid seg-fault. #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erykoff
force-pushed
the
tickets/DM-31466
branch
from
d661ace
to
94754a2
Compare
tests/test_PsfexPsf.py
Outdated
| @@ -268,6 +270,12 @@ def testPsfexDeterminer(self): | |||
| self.assertEqual(psf.computeBBox(), psf.computeKernelImage().getBBox()) | |||
| self.assertEqual(psf.computeBBox(), psf.getKernel().getBBox()) | |||
|
|
|||
| def test_dm_31466(self): | |||
| """Test that there is no seg-fault if order is set to 0.""" | |||
There was a problem hiding this comment.
I don't really object to this test really, but it doesn't actually test what the previous fail case was; setting this equal to zero never segfaultted at the config set point, the issue was that the config allowed the wrong value, and then segfaulted on running.
I think that this can be deleted, as this is really nothing more than a test that pexConfig options abide by their limits, and I'm sure that's tested extensively elsewhere.
mfisherlevine
approved these changes
Aug 19, 2021
erykoff
force-pushed
the
tickets/DM-31466
branch
from
94754a2
to
ab8916b
Compare
erykoff
force-pushed
the
tickets/DM-31466
branch
from
ab8916b
to
aa83dda
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.