Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-15034: Adapt to dimension refactor in daf_butler. #122

Merged
merged 1 commit into from Dec 13, 2018

Conversation

TallJimbo
Copy link
Member

@TallJimbo TallJimbo commented Dec 10, 2018

This is a significant simplification of the Gen3 ingest code, as most of the logic that used to live here has moved to either daf_butler or astro_metadata_translator.

Copy link
Contributor

@czwa czwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure any changes are critical, just some points to see if I'm misunderstanding something in the implementation.

python/lsst/obs/base/gen3/ingest.py Show resolved Hide resolved
python/lsst/obs/base/gen3/ingest.py Show resolved Hide resolved
python/lsst/obs/base/gen3/ingest.py Show resolved Hide resolved
@TallJimbo TallJimbo merged commit aa04350 into master Dec 13, 2018
@TallJimbo TallJimbo deleted the tickets/DM-15034 branch December 13, 2018 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants