DM-21246: Take advantage of deferred collection-passing to Butler. #200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timj
approved these changes
Jan 29, 2020
| to use for dataset ingest (`ConvertRepoTask.butler3` should never be | ||
| used directly). | ||
| def getCollections(self, datasetTypeName: str) -> List[str]: | ||
| """Return the set of collectoins a particular dataset type should be |
TallJimbo
force-pushed
the
tickets/DM-21246
branch
3 times, most recently
from
2a5473e
to
976cbb4
Compare
This would be a bit nicer if we could also defer collection-passing through writeCuratedCalibrations, but that's more work than I want to tack on to the end of this ticket, so I've created DM-23230 to cover it.
TallJimbo
force-pushed
the
tickets/DM-21246
branch
from
976cbb4
to
28ea268
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This would be a bit nicer if we could also defer collection-passing through writeCuratedCalibrations, but that's more work than I want to tack on to the end of this ticket, so I've created DM-23230 to cover it.