New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

preserve EUPS_USERDATA env var #41

Merged
merged 2 commits into from Oct 13, 2017

Conversation

Projects
None yet
2 participants
@jhoblitt
Member

jhoblitt commented Oct 12, 2017

This env var needs to be passed through for unit tests that cover code sections that call out to eups.

@jhoblitt jhoblitt requested a review from timj Oct 12, 2017

@timj

This comment has been minimized.

Show comment
Hide comment
@timj

timj Oct 12, 2017

Member

I'd rather the reformatting commit was distinct from the addition of the new variable.

Member

timj commented Oct 12, 2017

I'd rather the reformatting commit was distinct from the addition of the new variable.

jhoblitt added some commits Oct 13, 2017

reformat line wrapper env var array
As a multi-line, one string/env var per line declaration in improve
read-ability.
preserve EUPS_USERDATA env var
This env var is needed for unit tests that result in calls into eups.
@jhoblitt

This comment has been minimized.

Show comment
Hide comment
@jhoblitt

jhoblitt Oct 13, 2017

Member

The changeset has been split up as requested.

Member

jhoblitt commented Oct 13, 2017

The changeset has been split up as requested.

@jhoblitt jhoblitt merged commit 6144ab0 into master Oct 13, 2017

@ktlim ktlim deleted the tickets/DM-12201-eups-cache branch Aug 25, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment