-
Notifications
You must be signed in to change notification settings - Fork 1
SP-2514: NB 100 LSDB (very simple!) #67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
MelissaGraham
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I took a run through and have a few minor comments and a request to add just a bit more of the simple functionality to query and retrieve data from the LSDB files (not necessarily going so far as to execute a cross-match, still just data access).
- Section header format is to point a point after every number like 2. and 2.1. and then the text.
- "DIA Object" and "DIAObject" --> "DiaObject" to match convention
- Remove import and instantiation of butler (not used, not needed).
- The schema browser is linked to as a reference for all four catalogs but it only has Object and DiaObject -- can keep but should add that clarification maybe.
- Add a link to https://data.lsdb.io/ as the place to go for descriptions of the LSDB-formatted DP1 data.
- Find out more about this "lite" version of the object catalog, either from LSDB folk or by querying it. The description in data.lsdb.io is too opaque. What was trimmed, for example.
- Give "lite" it's own subsection just like the other three LSDB catalogs, so it's visible from the ToC and each catalog has it's own subsection.
- Add a bit more about partitioning and add maybe one default visualization, like the
plot_pixelsmethod. It should work for all, and gives a visualization of the partitions, and that's important for understanding how LSDB files are differently formatted in a way that's better for cross-matching. - Include column selection, queries, and data retrieval in the how-to. Like how S.3. of the PZ tutorial applies the column select and cone search, demo that for LSDB. And any other basic functionality. 310.1. uses it but isn't teaching it, 100-level is better place to teach it.
- Make it really clear that this is just a very simple tutorial and that there are much more LSDB tutorials in general (not just DP1-related) at https://docs.lsdb.io/en/latest/tutorials.html
- maybe in the intro add how LSDB is hosting lots of other HATS formatted data, too
2e097e3 to
e828760
Compare
d962e1f to
0275fb3
Compare
0275fb3 to
93c82ba
Compare
No description provided.