Skip to content

Conversation

@plazas
Copy link
Contributor

@plazas plazas commented Sep 11, 2025

No description provided.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link
Contributor

@MelissaGraham MelissaGraham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I took a run through and have a few minor comments and a request to add just a bit more of the simple functionality to query and retrieve data from the LSDB files (not necessarily going so far as to execute a cross-match, still just data access).

  • Section header format is to point a point after every number like 2. and 2.1. and then the text.
  • "DIA Object" and "DIAObject" --> "DiaObject" to match convention
  • Remove import and instantiation of butler (not used, not needed).
  • The schema browser is linked to as a reference for all four catalogs but it only has Object and DiaObject -- can keep but should add that clarification maybe.
  • Add a link to https://data.lsdb.io/ as the place to go for descriptions of the LSDB-formatted DP1 data.
  • Find out more about this "lite" version of the object catalog, either from LSDB folk or by querying it. The description in data.lsdb.io is too opaque. What was trimmed, for example.
  • Give "lite" it's own subsection just like the other three LSDB catalogs, so it's visible from the ToC and each catalog has it's own subsection.
  • Add a bit more about partitioning and add maybe one default visualization, like the plot_pixels method. It should work for all, and gives a visualization of the partitions, and that's important for understanding how LSDB files are differently formatted in a way that's better for cross-matching.
  • Include column selection, queries, and data retrieval in the how-to. Like how S.3. of the PZ tutorial applies the column select and cone search, demo that for LSDB. And any other basic functionality. 310.1. uses it but isn't teaching it, 100-level is better place to teach it.
  • Make it really clear that this is just a very simple tutorial and that there are much more LSDB tutorials in general (not just DP1-related) at https://docs.lsdb.io/en/latest/tutorials.html
  • maybe in the intro add how LSDB is hosting lots of other HATS formatted data, too

@MelissaGraham MelissaGraham self-requested a review September 17, 2025 23:22
@plazas plazas force-pushed the tickets/SP-2514 branch 2 times, most recently from d962e1f to 0275fb3 Compare September 19, 2025 14:29
@plazas plazas merged commit 49efc87 into main Sep 19, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants