Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Handling of authentification failure #1
This comment has been minimized.
This comment has been minimized.Show comment Hide comment
Thanks for your request and code. Agree on adding error handling, but I prefer to bubble up the error in the callback handlers instead of throwing an error.
So I changed your code a little bit:
In the signin callback you can now check for errors:
I hope you agree with the approach.