chore(install): deprecate legacy installer scripts; sync zh-TW README to launcher#319
Merged
Merged
Conversation
… to launcher The native desktop installer (INSTALL/launcher/) now supersedes the hand-rolled shell/batch/PowerShell installers. Mark those scripts as deprecated rather than removing them yet (one-cycle deprecation), and bring the Traditional-Chinese README in line with the launcher-based English README. - install_linux_mac.sh / install_windows.bat / lib/windows.ps1: add a DEPRECATED comment header and an on-run banner pointing at the desktop installer / PyPI; the shell and PS1 scripts prompt for confirmation before continuing. The legacy scripts still function for anyone who opts in. - README.zh-TW.md: replace the script-based Quick Start with the desktop- installer + PyPI flow mirroring README.md, and fix stale docs anchors (#docker-install -> #alternative-docker, etc.). This was the only remaining reference to install_linux_mac.sh. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
The native desktop installer (
INSTALL/launcher/, shipped to Releases) now supersedes the old hand-rolled installer scripts. Those scripts are orphaned — nothing referenced them except the Traditional-Chinese README. Per the migration plan we deprecate them for one cycle (rather than deleting outright) and bring the zh-TW README in line with the launcher-based English README.Changes
INSTALL/install_linux_mac.sh,INSTALL/install_windows.bat,INSTALL/lib/windows.ps1— add aDEPRECATEDcomment header and an on-run banner that points users at the desktop installer and the PyPI (uv tool install photomapai --torch-backend auto) path. The shell and PowerShell scripts now prompt for confirmation before proceeding, so anyone who still relies on them can opt in; nothing is removed yet.README.zh-TW.md— replace the script-based Quick Start (which was the only remaining reference toinstall_linux_mac.sh) with the desktop-installer + PyPI flow mirroringREADME.md, and fix stale docs anchors (#docker-install→#alternative-docker,#pypi-installation→#alternative-install-from-pypi,#executable-install→#manual-installation-from-source). Feature sections and the Chinese search-phrase examples are preserved.Notes
bash -npasses oninstall_linux_mac.sh.pwshwasn't available in the sandbox to parse-check the PS1, but the edit is a straightforwardWrite-Host/Read-Host/ifblock in the file's existing style.0.3.0plist version and the editable-install footgun the cleanup plan mentioned live insideinstall_linux_mac.sh; they're now moot (the script is deprecated and the launcher's macOS bundle stamps its version fromInfo.plist.template).🤖 Generated with Claude Code