Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Adparams #5

Closed
wants to merge 17 commits into
from
Commits on Jan 2, 2012
  1. add AdParamService

    Johannes Kaefer committed Jan 2, 2012
  2. when searching always use the IN parameter

    Johannes Kaefer committed Jan 2, 2012
    always convert params[param_name] to Array
  3. fix self.find method (predicates and selector)

    Johannes Kaefer committed Jan 2, 2012
  4. Merge branch 'fix_campaign_criteria' into adparams

    Johannes Kaefer committed Jan 2, 2012
Commits on Jan 3, 2012
  1. fix AdsCommon::Errors::TypeMismatchError: AdsCommon::Errors::TypeMism…

    Johannes Kaefer committed Jan 3, 2012
    …atchError: expected: 'Array', provided: 'Fixnum' for field 'values'
  2. fix AdsCommon::Errors::TypeMismatchError: AdsCommon::Errors::TypeMism…

    Johannes Kaefer committed Jan 3, 2012
    …atchError: expected: 'Array', provided: 'Fixnum' for field 'values'
  3. fix AdsCommon::Errors::TypeMismatchError: AdsCommon::Errors::TypeMism…

    Johannes Kaefer committed Jan 3, 2012
    …atchError: expected: 'Array', provided: 'Fixnum' for field 'values'
  4. try adparams service for first time

    Johannes Kaefer committed Jan 3, 2012
  5. Merge branch 'configurable_yml_paths' into adparams

    Johannes Kaefer committed Jan 3, 2012
  6. add adparam to adapi.rb

    Johannes Kaefer committed Jan 3, 2012
  7. create method

    Johannes Kaefer committed Jan 3, 2012
  8. operations has to be an array

    Johannes Kaefer committed Jan 3, 2012
Commits on Jan 4, 2012
  1. no error handling

    Johannes Kaefer committed Jan 4, 2012
  2. self.find returns now an array of keyword-objects

    Johannes Kaefer committed Jan 4, 2012
  3. cleanup keywords

    Johannes Kaefer committed Jan 4, 2012
    1) a Keyword-Object represents one Keyword returned via the AdGroupCriterionService
     1a) create now creates one keyword via the api
    2) self.find will return an array with keyword-objects
  4. shortend and match_type are troublesome

    Johannes Kaefer committed Jan 4, 2012
  5. cleanup

    Johannes Kaefer committed Jan 4, 2012