Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP
Browse files

Fixing code sniffer warnings

  • Loading branch information...
commit 6fb62f50805ac60eea538d5dc32af2961f7957ad 1 parent 53957a3
@lstrojny authored
View
1  src/FXMLRPC/Parser/XMLReaderParser.php
@@ -198,7 +198,6 @@ public function parse($xmlString, &$isFault)
case 'param':
case 'fault':
break 3;
- break;
case 'value':
$nextElements = array(
View
3  src/FXMLRPC/Serializer/XMLWriterSerializer.php
@@ -35,7 +35,7 @@ class XMLWriterSerializer implements SerializerInterface, ExtensionSupportInterf
{
private $writer;
- private $extension = array();
+ private $extensions = array();
public function __construct()
{
@@ -160,7 +160,6 @@ public function serialize($methodName, array $params = array())
default:
$node = get_object_vars($node);
goto struct;
- break;
}
break;
View
20 tests/FXMLRPC/ClientTest.php
@@ -26,6 +26,26 @@
class ClientTest extends \PHPUnit_Framework_TestCase
{
+ /**
+ * @var \FXMLRPC\Serializer\SerializerInterface
+ */
+ private $serializer;
+
+ /**
+ * @var \FXMLRPC\Parser\ParserInterface
+ */
+ private $parser;
+
+ /**
+ * @var \FXMLRPC\Transport\TransportInterface
+ */
+ private $transport;
+
+ /**
+ * @var Client
+ */
+ private $client;
+
public function setUp()
{
$this->serializer = $this->getMockBuilder('FXMLRPC\Serializer\SerializerInterface')
View
16 tests/FXMLRPC/Integration/IntegrationTest.php
@@ -34,7 +34,7 @@ class IntegrationTest extends \PHPUnit_Framework_TestCase
{
private $clients = array();
- private $dependencies = array();
+ private $clientDependencies = array();
private $pos = 0;
@@ -182,7 +182,7 @@ private function generateAllPossibleCombinations($combinations)
if ($combinations) {
for ($i = 0; $i < count($combinations[0]); ++$i) {
$temp = $combinations;
- $this->dependencies[$this->pos] = $combinations[0][$i];
+ $this->clientDependencies[$this->pos] = $combinations[0][$i];
array_shift($temp);
$this->pos++;
$this->generateAllPossibleCombinations($temp);
@@ -190,14 +190,14 @@ private function generateAllPossibleCombinations($combinations)
} else {
$client = new FXMLRPC\Client(
'http://localhost:9090/',
- $this->dependencies[0],
- $this->dependencies[1],
- $this->dependencies[2]
+ $this->clientDependencies[0],
+ $this->clientDependencies[1],
+ $this->clientDependencies[2]
);
- if ($this->dependencies[3]) {
- $client = new \FXMLRPC\Timing\TimingDecorator($client, $this->dependencies[3]);
+ if ($this->clientDependencies[3]) {
+ $client = new \FXMLRPC\Timing\TimingDecorator($client, $this->clientDependencies[3]);
}
- $this->clients[] = array($client, $this->dependencies[0], $this->dependencies[1], $this->dependencies[2]);
+ $this->clients[] = array($client, $this->clientDependencies[0], $this->clientDependencies[1], $this->clientDependencies[2]);
}
$this->pos--;
}
Please sign in to comment.
Something went wrong with that request. Please try again.