version could be properties which defined in project gav

[cccfeng]

pom-explorer/pom-explorer-core/src/main/java/fr/lteconsulting/pomexplorer/Project.java

Line 96 in db4246c

throw new IllegalStateException("project does not have version and neither is a parent pom defined");

parent -->
child1 (g - a -v)
child2 (groupId - artifactId - ${xxx.version})

xxx.version is the property in parent artifactId

[robstoll]

Thanks for your input, I am not really sure if I get you right. Do you mean something as the following:
parent

<properties><xxx.version>1.0</xxx.version></properties>

child

<parent>...</parent>
<version>${xxx.version}</version>

[cccfeng]

You got it. I found this scene in a real project.

[robstoll]

But project.getVersion() is not null in such a case (it's ${xxx.version}), so the problem that this exception is thrown must be elsewhere.

[robstoll]

It seems to me that an interpolation is required here so that the version resolves to what is defined in the parent (or wherever it was defined). Is that your actual problem?

[cccfeng]

Yes. In fact the program try to compare version and "${parent.version}" , so it is the same that the version equals ${xxx.version} or something else

[robstoll]

Ok, I think now we are getting to the point 😄
You do not experience the exception in line 96 but in line 105 Non resolved project's GAV: ...
Would you like to try solve the problem yourself? I could give you some hints.

[cccfeng]

Ok,I would like to try it. Is the logic right to solve this problem ?
when version is not null, add the code

1. whether the version resolved ? if not
2. whether the version is a maven val, start with ${ and end with }
3. if version is a maven val , then try to get from self properties.
4. when self properties is null , try to get from it's parent gav
5. or else throw the RuntimeException

[robstoll]

I think that's more or less it. The good thing though, there is already logic for this Project::interpolateValue. I have created two regression tests for you. They should be green at the end. Feel free to enhance the tests they are kind of basic. Have fun and if you have questions keep them posted here.

[cccfeng]

Got it. I will try to finish it.

[robstoll]

Sorry, I only pushed the regression test to my fork but not to this repo. It is now inlcuded here as well: #70